Flip around where AsSpan is called with string comparisons in tests.

Author: eerhardt

src/DataProtection/DataProtection/test/Microsoft.AspNetCore.DataProtection.Tests/Cng/GcmAuthenticatedEncryptorTests.cs

@@ -100,6 +100,6 @@ public void Encrypt_KnownKey()
         //         | 00 00 00 00 (postBuffer)
 
         string retValAsString = Convert.ToBase64String(retVal);
-        Assert.Equal("AAAAAAECAwQFBgcICQoLDA0ODxAREhMUFRYXGBkaG0O2kY0NZtmh2UQtXY5B2jlgnOgAAAAA".AsSpan(), retValAsString);
+        Assert.Equal("AAAAAAECAwQFBgcICQoLDA0ODxAREhMUFRYXGBkaG0O2kY0NZtmh2UQtXY5B2jlgnOgAAAAA", retValAsString);
     }
 }

src/DataProtection/DataProtection/test/Microsoft.AspNetCore.DataProtection.Tests/KeyManagement/KeyRingBasedDataProtectorTests.cs

@@ -45,8 +45,8 @@ public void Protect_EncryptsToDefaultProtector_MultiplePurposes()
             .Setup(o => o.Encrypt(It.IsAny<ArraySegment<byte>>(), It.IsAny<ArraySegment<byte>>()))
             .Returns<ArraySegment<byte>, ArraySegment<byte>>((actualPlaintext, actualAad) =>
             {
-                Assert.Equal(expectedPlaintext.AsSpan(), actualPlaintext);
-                Assert.Equal(expectedAad.AsSpan(), actualAad);
+                Assert.Equal(expectedPlaintext, actualPlaintext.AsSpan());
+                Assert.Equal(expectedAad, actualAad.AsSpan());
                 return new byte[] { 0x23, 0x29, 0x31, 0x37 }; // ciphertext + tag
             });
 
@@ -83,8 +83,8 @@ public void Protect_EncryptsToDefaultProtector_SinglePurpose()
             .Setup(o => o.Encrypt(It.IsAny<ArraySegment<byte>>(), It.IsAny<ArraySegment<byte>>()))
             .Returns<ArraySegment<byte>, ArraySegment<byte>>((actualPlaintext, actualAad) =>
             {
-                Assert.Equal(expectedPlaintext.AsSpan(), actualPlaintext);
-                Assert.Equal(expectedAad.AsSpan(), actualAad);
+                Assert.Equal(expectedPlaintext, actualPlaintext.AsSpan());
+                Assert.Equal(expectedAad, actualAad.AsSpan());
                 return new byte[] { 0x23, 0x29, 0x31, 0x37 }; // ciphertext + tag
             });
 
@@ -423,8 +423,8 @@ public void Unprotect_KeyRevoked_RevocationAllowed_ReturnsOriginalData_SetsRevok
             .Setup(o => o.Decrypt(It.IsAny<ArraySegment<byte>>(), It.IsAny<ArraySegment<byte>>()))
             .Returns<ArraySegment<byte>, ArraySegment<byte>>((actualCiphertext, actualAad) =>
             {
-                Assert.Equal(expectedCiphertext.AsSpan(), actualCiphertext);
-                Assert.Equal(expectedAad.AsSpan(), actualAad);
+                Assert.Equal(expectedCiphertext, actualCiphertext.AsSpan());
+                Assert.Equal(expectedAad, actualAad.AsSpan());
                 return expectedPlaintext;
             });
         var mockDescriptor = new Mock<IAuthenticatedEncryptorDescriptor>();
@@ -470,8 +470,8 @@ public void Unprotect_IsAlsoDefaultKey_Success_NoMigrationRequired()
             .Setup(o => o.Decrypt(It.IsAny<ArraySegment<byte>>(), It.IsAny<ArraySegment<byte>>()))
             .Returns<ArraySegment<byte>, ArraySegment<byte>>((actualCiphertext, actualAad) =>
             {
-                Assert.Equal(expectedCiphertext.AsSpan(), actualCiphertext);
-                Assert.Equal(expectedAad.AsSpan(), actualAad);
+                Assert.Equal(expectedCiphertext, actualCiphertext.AsSpan());
+                Assert.Equal(expectedAad, actualAad.AsSpan());
                 return expectedPlaintext;
             });
         var mockDescriptor = new Mock<IAuthenticatedEncryptorDescriptor>();
@@ -519,8 +519,8 @@ public void Unprotect_IsNotDefaultKey_Success_RequiresMigration()
             .Setup(o => o.Decrypt(It.IsAny<ArraySegment<byte>>(), It.IsAny<ArraySegment<byte>>()))
             .Returns<ArraySegment<byte>, ArraySegment<byte>>((actualCiphertext, actualAad) =>
             {
-                Assert.Equal(expectedCiphertext.AsSpan(), actualCiphertext);
-                Assert.Equal(expectedAad.AsSpan(), actualAad);
+                Assert.Equal(expectedCiphertext, actualCiphertext.AsSpan());
+                Assert.Equal(expectedAad, actualAad.AsSpan());
                 return expectedPlaintext;
             });
         var mockDescriptor = new Mock<IAuthenticatedEncryptorDescriptor>();
@@ -594,8 +594,8 @@ public void CreateProtector_ChainsPurposes()
             .Setup(o => o.Encrypt(It.IsAny<ArraySegment<byte>>(), It.IsAny<ArraySegment<byte>>()))
             .Returns<ArraySegment<byte>, ArraySegment<byte>>((actualPlaintext, actualAad) =>
             {
-                Assert.Equal(expectedPlaintext.AsSpan(), actualPlaintext);
-                Assert.Equal(expectedAad.AsSpan(), actualAad);
+                Assert.Equal(expectedPlaintext, actualPlaintext.AsSpan());
+                Assert.Equal(expectedAad, actualAad.AsSpan());
                 return new byte[] { 0x23, 0x29, 0x31, 0x37 }; // ciphertext + tag
             });
 

src/Http/Headers/test/CacheControlHeaderValueTest.cs

@@ -47,14 +47,14 @@ public void Properties_SetAndGetAllProperties_SetValueReturnedInGetter()
         Assert.Throws<FormatException>(() => cacheControl.NoCacheHeaders.Add("invalid PLACEHOLDER"));
         cacheControl.NoCacheHeaders.Add("PLACEHOLDER");
         Assert.Single(cacheControl.NoCacheHeaders);
-        Assert.Equal("PLACEHOLDER".AsSpan(), cacheControl.NoCacheHeaders.First());
+        Assert.Equal("PLACEHOLDER", cacheControl.NoCacheHeaders.First().AsSpan());
 
         Assert.NotNull(cacheControl.PrivateHeaders);
         Assert.Throws<ArgumentException>(() => cacheControl.PrivateHeaders.Add(null));
         Assert.Throws<FormatException>(() => cacheControl.PrivateHeaders.Add("invalid PLACEHOLDER"));
         cacheControl.PrivateHeaders.Add("PLACEHOLDER");
         Assert.Single(cacheControl.PrivateHeaders);
-        Assert.Equal("PLACEHOLDER".AsSpan(), cacheControl.PrivateHeaders.First());
+        Assert.Equal("PLACEHOLDER", cacheControl.PrivateHeaders.First().AsSpan());
 
         // NameValueHeaderValue collection property
         Assert.NotNull(cacheControl.Extensions);