feedback/comments

Author: pavelsavara

Diff for: src/Components/Components/src/RenderTree/Renderer.cs

@@ -1103,10 +1103,14 @@ private void HandleExceptionViaErrorBoundary(Exception error, ComponentState? er
     /// <param name="disposing"><see langword="true"/> if this method is being invoked by <see cref="IDisposable.Dispose"/>, otherwise <see langword="false"/>.</param>
     protected virtual void Dispose(bool disposing)
     {
+        //  in theory multiple threads could be racing for this
         lock (_lockObject)
         {
             if (_rendererIsDisposed)
             {
+                // quitting synchronously as soon as possible is avoiding
+                // possible async dispatch to another thread and
+                // possible deadlock on synchronous `done.Wait()` below.
                 return;
             }
         }

Diff for: src/Components/Components/test/Rendering/RendererSynchronizationContextTest.cs

@@ -771,6 +771,9 @@ public async Task InvokeAsync_SyncWorkInAsyncTaskIsCompletedFirst()
         await Task.Yield();
         actual = "First";
 
+        // this test assumes RendererSynchronizationContext optimization, which makes it synchronous execution.
+        // with multi-threading runtime and WebAssemblyDispatcher `InvokeAsync` will be executed asynchronously ordering it differently.
+        // See https://github.com/dotnet/aspnetcore/pull/52724#issuecomment-1895566632
         var invokeTask = context.InvokeAsync(async () =>
         {
             // When the sync context is idle, queued work items start synchronously

Diff for: src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs

@@ -27,6 +27,9 @@ public void CanDispatchAsyncWorkToSyncContext()
 
         appElement.FindElement(By.Id("run-async-with-dispatch")).Click();
 
+        // this test assumes RendererSynchronizationContext optimization, which makes it synchronous execution.
+        // with multi-threading runtime and WebAssemblyDispatcher `InvokeAsync` will be executed asynchronously ordering it differently.
+        // See https://github.com/dotnet/aspnetcore/pull/52724#issuecomment-1895566632
         Browser.Equal("First Second Third Fourth Fifth", () => result.Text);
     }
 }