Quarantine Http2ConnectionTests.StreamPool_StreamIsInvalidState_DontReturnedToPool

[github-actions]

Failing Test(s)

Microsoft.AspNetCore.Server.Kestrel.Core.Tests.Http2ConnectionTests.StreamPool_StreamIsInvalidState_DontReturnedToPool

Error Message

Assert.True() Failure
Expected: True
Actual:   False

The test intentionally puts a stream into an invalid state (by throwing InvalidOperationException after writing to the response) and then asserts the stream is not returned to the pool.

Stacktrace

Details

at Microsoft.AspNetCore.Server.Kestrel.Core.Tests.Http2ConnectionTests.StreamPool_StreamIsInvalidState_DontReturnedToPool()
  in /_/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs:line 611

Logs

Details

[0.016s] TestLifetime Information: Starting test StreamPool_StreamIsInvalidState_DontReturnedToPool
[0.030s] Http2 Trace: Connection sending SETTINGS frame for stream ID 0
[0.030s] Http2 Trace: sending WINDOW_UPDATE frame for stream ID 0
[0.030s] Http2 Error: Connection id "TestConnectionId": An unhandled exception was thrown by the application.
System.InvalidOperationException: Put the stream into an invalid state by throwing after writing to response.
   at Microsoft.AspNetCore.Server.Kestrel.Core.Tests.Http2ConnectionTests...StreamPool_StreamIsInvalidState_DontReturnedToPool
[0.034s] Http2 Debug: HTTP/2 stream error "INTERNAL_ERROR". A Reset is being sent to the stream.
[0.058s] Http2ConnectionTests Error: Test threw an exception.
Xunit.Sdk.TrueException: Assert.True() Failure

Build

https://dev.azure.com/dnceng-public/public/_build/results?buildId=1362336

Note

🔒 Integrity filter blocked 12 items

The following items were blocked because they don't meet the GitHub integrity level.

• #65815 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #65817 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #65827 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #65816 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #66130 issue_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #66135 issue_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #40626 search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #46028 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #49286 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #54846 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #55092 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #55707 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by Daily Test Quarantine Management · ● 25.1M · ◷

[github-actions]

Investigation

StreamPool_StreamIsInvalidState_DontReturnedToPool has failed 2 times in the last 30 days (builds 1362336, 1357441).

Failure pattern: Assert.True() Failure — the assertion that the stream is NOT returned to the pool fails, meaning the stream IS being returned to the pool despite being in an invalid state.

Test context: The test verifies that when an HTTP/2 stream's application code throws an InvalidOperationException, the stream is put into an invalid state and is NOT returned to the Http2StreamPool (since an invalid stream could corrupt pool state if reused).

Root cause: The race condition appears to be between:

1. The exception handler that marks the stream as invalid
2. The cleanup code that returns the stream to the pool

If the cleanup runs before the invalid state is set (due to threading), the stream is returned to the pool while still considered valid. This may happen when the InvalidOperationException is thrown asynchronously (e.g., from the response body writer) and the stream completes before the exception is fully propagated.

Recommendation: Review Http2Stream.Dispose() and Http2Connection._completedStreams handling to ensure that the invalid state check happens AFTER all exception handling is complete and before the stream is returned to the pool. The SetResult() call timing mentioned in the test's comment is key to understanding this race.

Note

🔒 Integrity filter blocked 12 items

The following items were blocked because they don't meet the GitHub integrity level.

• #65815 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #65817 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #65827 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #65816 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #66130 issue_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #66135 issue_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #40626 search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #46028 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #49286 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #54846 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #55092 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #55707 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by Daily Test Quarantine Management · ● 25.1M · ◷