[test-quarantine] Stabilize the async NavigationException E2E test - #68269
Open
Yuvan111 wants to merge 3 commits into
Open
[test-quarantine] Stabilize the async NavigationException E2E test#68269Yuvan111 wants to merge 3 commits into
Yuvan111 wants to merge 3 commits into
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Thanks for your PR, @Yuvan111. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to de-flake the NavigationException_InAsyncContext_DoesNotBecomeUnobservedTaskException server-rendering E2E test by adding an explicit wait for the “unobserved exceptions” counter to appear after the circular redirect sequence completes, and then removing the quarantine marker once the timing race is addressed.
Changes:
- Removed the
[QuarantinedTest]attribute fromNavigationException_InAsyncContext_DoesNotBecomeUnobservedTaskException. - Added an explicit wait for the
unobserved-exceptions-countelement before asserting its value.
Comment on lines
+301
to
+305
| // Wait for the counter element to appear and stabilize. | ||
| // The circular redirect flow performs 3 retry attempts with multiple render cycles, | ||
| // so we need to wait for the page to fully settle before asserting. | ||
| Browser.Exists(By.Id("unobserved-exceptions-count"), TimeSpan.FromSeconds(10)); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilize the async NavigationException E2E test
Description
The circular redirect scenario performs three retry attempts across multiple render cycles. The test could assert the unobserved exception count before the page had fully settled, causing intermittent failures.
The test now explicitly waits up to 10 seconds for the exception counter to appear and allows pending render cycles to finish before reading its value. This preserves the original assertion that navigation exceptions do not become unobserved task exceptions while making the test resilient to slower CI environments.
This change also removes the quarantine attribute because the timing-related instability is addressed.
Validation / Investigation
NavigationException_InAsyncContext_DoesNotBecomeUnobservedTaskException100 consecutive times successfully.RedirectionTestclass 50 consecutive times successfully.Changes
Fixes #66118