Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change]: WithAccessKeyAuthenticaton and WithPasswordAuthentication create a keyvault resource in the app model #2889

Closed
1 of 3 tasks
davidfowl opened this issue Mar 25, 2025 · 0 comments · Fixed by #2870
Assignees
Labels
⛓️‍💥 breaking-change Issues or PRs tracking breaking changes. doc-idea Indicates issues that are suggestions for new topics [org][type][category] in-pr Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest.
Milestone

Comments

@davidfowl
Copy link
Member

davidfowl commented Mar 25, 2025

Description

Relevant change dotnet/aspire#8171

Resources no longer

Version

.NET Aspire 9.2

Previous behavior

Before azd would automatically create and manage bicep resources and these were invisible to the app model so they could not be managed or customized in C#.

New behavior

In 9.2 we changed calling WithKeyAccessAuthenticaton on CosmosDb and AzureRedis or WithPasswordAuthentication would add an empty keyVaultName parameter as a known parameter in the bicep. Now we directly create the key vault resource (or allow you to pass in a reference to another AzureKeyVault resource where the secret will be stored). The key vault secret names for connection strings are now named connectionstrings--{resourcename} to avoid potential conflicts with other connection strings in existing key vaults.

Type of breaking change

  • Binary incompatible: Existing binaries might encounter a breaking change in behavior, such as failure to load or execute, and if so, require recompilation.
  • Source incompatible: When recompiled using the new SDK or component or to target the new runtime, existing source code might require source changes to compile successfully.
  • Behavioral change: Existing binaries might behave differently at run time.

Reason for change

Moving resources to the app host makes it easier to customize and manage. You can now share a key vault across multiple resources or use an existing key vault to manage connection strings with secrets.

Recommended action

There is currently not work around.

Affected APIs


Associated WorkItem - 416256

@davidfowl davidfowl added doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri1 High priority, do before Pri2 and Pri3 ⛓️‍💥 breaking-change Issues or PRs tracking breaking changes. labels Mar 25, 2025
@dotnetrepoman dotnetrepoman bot added the ⌚ Not Triaged Not triaged label Mar 25, 2025
@IEvangelist IEvangelist added 🗺️ reQUEST Triggers an issue to be imported into Quest. and removed ⌚ Not Triaged Not triaged labels Mar 25, 2025
@IEvangelist IEvangelist added this to the 9.2 milestone Mar 25, 2025
@dotnetrepoman dotnetrepoman bot added 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. and removed 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. labels Mar 25, 2025
IEvangelist added a commit to IEvangelist/docs-aspire that referenced this issue Mar 25, 2025
@dotnetrepoman dotnetrepoman bot added the 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. label Mar 30, 2025
@IEvangelist IEvangelist moved this from 🔖 Ready to 👀 In review in dotnet/docs March 2025 sprint project Mar 30, 2025
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Apr 1, 2025
IEvangelist added a commit to IEvangelist/docs-aspire that referenced this issue Apr 2, 2025
IEvangelist added a commit that referenced this issue Apr 3, 2025
* Added breaking changes for 9.2, fixes #2888 and fixes #2889

* Correct TOC

* Add clarifying type name

* Fixes #2899

* Added new breaking changes docs

* Remove link

* Correct MD lint error/warnings
IEvangelist added a commit to IEvangelist/docs-aspire that referenced this issue Apr 3, 2025
* Added breaking changes for 9.2, fixes dotnet#2888 and fixes dotnet#2889

* Correct TOC

* Add clarifying type name

* Fixes dotnet#2899

* Added new breaking changes docs

* Remove link

* Correct MD lint error/warnings
@adegeo adegeo removed the 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. label Apr 9, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in dotnet/docs March 2025 sprint project Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛓️‍💥 breaking-change Issues or PRs tracking breaking changes. doc-idea Indicates issues that are suggestions for new topics [org][type][category] in-pr Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants