From b8bdf2bdf206bc3a98beb59748fd0ed3d2fbb10b Mon Sep 17 00:00:00 2001 From: Alex Crome Date: Thu, 20 Feb 2025 12:14:05 +0000 Subject: [PATCH 1/4] Add Meter name to Kafka Metrics --- docs/messaging/kafka-integration.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/docs/messaging/kafka-integration.md b/docs/messaging/kafka-integration.md index 280ee49c74..53cba62a85 100644 --- a/docs/messaging/kafka-integration.md +++ b/docs/messaging/kafka-integration.md @@ -334,14 +334,15 @@ The .NET Aspire Apache Kafka integration dos not emit distributed traces. The .NET Aspire Apache Kafka integration emits the following metrics using OpenTelemetry: -- `messaging.kafka.network.tx` -- `messaging.kafka.network.transmitted` -- `messaging.kafka.network.rx` -- `messaging.kafka.network.received` -- `messaging.publish.messages` -- `messaging.kafka.message.transmitted` -- `messaging.receive.messages` -- `messaging.kafka.message.received` +- `Aspire.Confluent.Kafka` + - `messaging.kafka.network.tx` + - `messaging.kafka.network.transmitted` + - `messaging.kafka.network.rx` + - `messaging.kafka.network.received` + - `messaging.publish.messages` + - `messaging.kafka.message.transmitted` + - `messaging.receive.messages` + - `messaging.kafka.message.received` ## See also From dc2d65ff61a0049467be27f8e3792c46909ba5a3 Mon Sep 17 00:00:00 2001 From: Alex Crome Date: Thu, 20 Feb 2025 12:16:27 +0000 Subject: [PATCH 2/4] Correct styling of meter name --- docs/messaging/kafka-integration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/messaging/kafka-integration.md b/docs/messaging/kafka-integration.md index 53cba62a85..e71a8d8f28 100644 --- a/docs/messaging/kafka-integration.md +++ b/docs/messaging/kafka-integration.md @@ -334,7 +334,7 @@ The .NET Aspire Apache Kafka integration dos not emit distributed traces. The .NET Aspire Apache Kafka integration emits the following metrics using OpenTelemetry: -- `Aspire.Confluent.Kafka` +- Aspire.Confluent.Kafka - `messaging.kafka.network.tx` - `messaging.kafka.network.transmitted` - `messaging.kafka.network.rx` From 02c2975f75a5986c96aa8441a1b31b4bbc5b4fce Mon Sep 17 00:00:00 2001 From: David Pine Date: Thu, 20 Feb 2025 08:41:52 -0600 Subject: [PATCH 3/4] Apply suggestions from code review --- docs/messaging/kafka-integration.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/messaging/kafka-integration.md b/docs/messaging/kafka-integration.md index e71a8d8f28..a5f21c31db 100644 --- a/docs/messaging/kafka-integration.md +++ b/docs/messaging/kafka-integration.md @@ -335,14 +335,14 @@ The .NET Aspire Apache Kafka integration dos not emit distributed traces. The .NET Aspire Apache Kafka integration emits the following metrics using OpenTelemetry: - Aspire.Confluent.Kafka - - `messaging.kafka.network.tx` - - `messaging.kafka.network.transmitted` - - `messaging.kafka.network.rx` - - `messaging.kafka.network.received` - - `messaging.publish.messages` - - `messaging.kafka.message.transmitted` - - `messaging.receive.messages` - - `messaging.kafka.message.received` + - `messaging.kafka.network.tx` + - `messaging.kafka.network.transmitted` + - `messaging.kafka.network.rx` + - `messaging.kafka.network.received` + - `messaging.publish.messages` + - `messaging.kafka.message.transmitted` + - `messaging.receive.messages` + - `messaging.kafka.message.received` ## See also From 9edea30c77071df739a98485bc421ccf04ab1f0d Mon Sep 17 00:00:00 2001 From: David Pine Date: Thu, 20 Feb 2025 08:42:02 -0600 Subject: [PATCH 4/4] Apply suggestions from code review --- docs/messaging/kafka-integration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/messaging/kafka-integration.md b/docs/messaging/kafka-integration.md index a5f21c31db..ee7ef940c7 100644 --- a/docs/messaging/kafka-integration.md +++ b/docs/messaging/kafka-integration.md @@ -334,7 +334,7 @@ The .NET Aspire Apache Kafka integration dos not emit distributed traces. The .NET Aspire Apache Kafka integration emits the following metrics using OpenTelemetry: -- Aspire.Confluent.Kafka +- `Aspire.Confluent.Kafka` - `messaging.kafka.network.tx` - `messaging.kafka.network.transmitted` - `messaging.kafka.network.rx`