Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C# 14-Fundamentals and reference]: New Feature - VB supports unmanaged constraint #44190

Closed
BillWagner opened this issue Jan 8, 2025 · 0 comments · Fixed by #44636
Closed

[C# 14-Fundamentals and reference]: New Feature - VB supports unmanaged constraint #44190

BillWagner opened this issue Jan 8, 2025 · 0 comments · Fixed by #44636
Assignees
@BillWagner
Labels
🏁 Release: .NET 10 Work items for the .NET 10 release dotnet-csharp/svc in-pr This issue will be closed (fixed) by an active pull request. 📌 seQUESTered Identifies that an issue has been imported into Quest. resolved-by-customer whats-new/subsvc

Comments

@BillWagner
Copy link
Member

BillWagner commented Jan 8, 2025 •
edited by sequestor bot
Loading

Visual Studio release

17.13.p3

Link to speclet

  • N/A, treated as a bug fix

Link to Pull request

New behavior

Actually merged in VS 17.3.p2

VB now recognizes the unmanaged generic constraint, and enforces it. In previous versions, any attempt to use a type with the unmanaged constraint caused an unexpected and unhelpful error message.

Language reference tasks

No response

Everyday C# tasks

No response

Associated WorkItem - 360916
@BillWagner BillWagner self-assigned this Jan 8, 2025
@BillWagner BillWagner added the 🗺️ reQUEST Triggers an issue to be imported into Quest. label Jan 8, 2025
@dotnet-policy-service dotnet-policy-service bot added the ⌚ Not Triaged Not triaged label Jan 8, 2025
@dotnetrepoman dotnetrepoman bot added the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Jan 8, 2025
@dotnet-policy-service dotnet-policy-service bot removed ⌚ Not Triaged Not triaged 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. labels Jan 8, 2025
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Jan 9, 2025
@BillWagner BillWagner moved this from 🔖 Ready to 🏗 In progress in dotnet/docs January 2025 sprint project Jan 30, 2025
@dotnetrepoman dotnetrepoman bot added the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Jan 30, 2025
@dotnet-policy-service dotnet-policy-service bot removed the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Jan 30, 2025
BillWagner added a commit to BillWagner/docs that referenced this issue Jan 31, 2025
@BillWagner
Add VB new features
092717f 
- Fixes dotnet#44190:  Add note that Visual Basic can consume types (defined in C#) that specify the `unmanaged` constraint.
- Fixes dotnet#44174: VB Overload resolution respects the OverloadResolutionPriorityAttribute.

In these changes, I made the necessary updates for accuracy with the current compiler. Then, I did an edit for style and updated per style.

You may want to review the two commits separately to see the semantic changes distinct from the grammar and style changes.
@BillWagner BillWagner mentioned this issue Jan 31, 2025
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr This issue will be closed (fixed) by an active pull request. label Jan 31, 2025
@dotnetrepoman dotnetrepoman bot added the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Jan 31, 2025
@BillWagner BillWagner moved this from 🏗 In progress to 👀 In review in dotnet/docs January 2025 sprint project Jan 31, 2025
@dotnet-policy-service dotnet-policy-service bot removed the 🗺️ mapQUEST Only used as a way to mark an issue as updated for quest. RepoMan should instantly remove it. label Jan 31, 2025
BillWagner added a commit that referenced this issue Jan 31, 2025
@BillWagner @gewarren
Add VB new features (#44636)
5a6a5ea 
* Add VB new features

- Fixes #44190:  Add note that Visual Basic can consume types (defined in C#) that specify the `unmanaged` constraint.
- Fixes #44174: VB Overload resolution respects the OverloadResolutionPriorityAttribute.

In these changes, I made the necessary updates for accuracy with the current compiler. Then, I did an edit for style and updated per style.

You may want to review the two commits separately to see the semantic changes distinct from the grammar and style changes.

* edit and freshness pass

* word choice

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <[email protected]>

* rework paragraph on `unmanaged`

Try to make this restriction more clear.

* Update docs/visual-basic/programming-guide/language-features/data-types/generic-types.md

Co-authored-by: Genevieve Warren <[email protected]>

---------

Co-authored-by: Genevieve Warren <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in dotnet/docs January 2025 sprint project Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillWagner BillWagner

Labels
🏁 Release: .NET 10 Work items for the .NET 10 release dotnet-csharp/svc in-pr This issue will be closed (fixed) by an active pull request. 📌 seQUESTered Identifies that an issue has been imported into Quest. resolved-by-customer whats-new/subsvc
Projects
No open projects
dotnet/docs January 2025 sprint project
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add VB new features BillWagner/docs
1 participant
@BillWagner