Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ResourceUtilizationInstruments constants to Shared project #5813

Closed
evgenyfedorov2 opened this issue Jan 24, 2025 · 0 comments · Fixed by #5844
Closed

Move ResourceUtilizationInstruments constants to Shared project #5813

evgenyfedorov2 opened this issue Jan 24, 2025 · 0 comments · Fixed by #5844
Assignees
@amadeuszl
Labels
area-resourcemonitoring work in progress 🚧

Comments

@evgenyfedorov2
Copy link
Contributor

ResourceUtilizationInstruments is an internal class with constant strings such Meter and Instrument names which are used by Resource Monitoring and Health check libraries. Since the class is internal, it can't be accessed from outside, e.g. Health Check must use hard-coded strings.

Consider moving the ResourceUtilizationInstruments to Shared project and inject its source code to all necessary projects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amadeuszl amadeuszl

Labels
area-resourcemonitoring work in progress 🚧
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move ResourceUtilizationInstruments to Shared project amadeuszl/extensions
2 participants
@amadeuszl @evgenyfedorov2