Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP switch from NewtonsoftLanguageServer to SystemTextJsonLanguageServer #18068

Open
0101 opened this issue Nov 27, 2024 · 1 comment
Open

LSP switch from NewtonsoftLanguageServer to SystemTextJsonLanguageServer #18068

0101 opened this issue Nov 27, 2024 · 1 comment
Labels
Area-LSP Related to Language Server Protocol
Milestone

Comments

@0101
Copy link
Contributor

0101 commented Nov 27, 2024

Newtonsoft is less performant and will be deprecated.

Some work is needed here to support polymorphic (de)serialization which Newtonsoft handles but STJ doesn't.

@charlesroddie
Copy link
Contributor

If performance is a consideration, why not use CBOR?

For the few cases where external APIs require us to use json, we moved to System.Text.Json from Newtonsoft to remove trim warnings, but doing any manual serialisation and deserialization is a huge pain: the library is entirely designed around automatic deserialization using C# types-as-code style and source generators.

@T-Gro T-Gro modified the milestones: Backlog, March 2025 Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-LSP Related to Language Server Protocol
Projects
Status: New
Development

No branches or pull requests

3 participants