[tests] Add new cecil test to verify the correct [BindingImpl] on methods using blocks. (#23680)

Author: rolfbjarne

src/Accessibility/AXSettings.cs

@@ -58,6 +58,7 @@ public static bool IsAssistiveAccessEnabled {
 		[SupportedOSPlatform ("maccatalyst18.0")]
 		[SupportedOSPlatform ("macos15.0")]
 		[SupportedOSPlatform ("tvos18.0")]
+		[BindingImpl (BindingImplOptions.Optimizable)]
 		public unsafe static void OpenSettingsFeature (AXSettingsFeature feature, Action<NSError?> completionHandler)
 		{
 			delegate* unmanaged<IntPtr, IntPtr, void> trampoline = &OpenSettingsFeatureCompletionHandler;

src/Security/SecProtocolOptions.cs

@@ -463,6 +463,7 @@ public void SetTlsPreSharedKeyIdentityHint (DispatchData pskIdentityHint)
 		[SupportedOSPlatform ("macos")]
 		[SupportedOSPlatform ("ios")]
 		[SupportedOSPlatform ("maccatalyst")]
+		[BindingImpl (BindingImplOptions.Optimizable)]
 		public void SetChallengeBlock (SecProtocolChallenge challenge, DispatchQueue queue)
 		{
 			unsafe {
@@ -487,6 +488,7 @@ public void SetChallengeBlock (SecProtocolChallenge challenge, DispatchQueue que
 		[SupportedOSPlatform ("macos")]
 		[SupportedOSPlatform ("ios")]
 		[SupportedOSPlatform ("maccatalyst")]
+		[BindingImpl (BindingImplOptions.Optimizable)]
 		public void SetVerifyBlock (SecProtocolVerify verify, DispatchQueue queue)
 		{
 			unsafe {
@@ -511,6 +513,7 @@ public void SetVerifyBlock (SecProtocolVerify verify, DispatchQueue queue)
 		[SupportedOSPlatform ("macos")]
 		[SupportedOSPlatform ("ios13.0")]
 		[SupportedOSPlatform ("maccatalyst")]
+		[BindingImpl (BindingImplOptions.Optimizable)]
 		public void SetPreSharedKeySelectionBlock (SecProtocolPreSharedKeySelection selection, DispatchQueue queue)
 		{
 			unsafe {

src/VideoToolbox/VTRawProcessingSession.cs

@@ -114,6 +114,7 @@ unsafe static extern VTStatus VTRAWProcessingSessionSetParameterChangedHander (
 
 		/// <summary>Provide a callback that will be called when the VTRawProcessingPlugin changes the set of processing parameters.</summary>
 		/// <param name="handler">The callback that will be called. Set to null to remove the current handler.</param>
+		[BindingImpl (BindingImplOptions.Optimizable)]
 		public unsafe VTStatus SetParameterChangedHandler (VTRawProcessingParameterChangeHandler? handler)
 		{
 			if (handler is null) {
@@ -147,6 +148,7 @@ unsafe static extern VTStatus VTRAWProcessingSessionProcessFrame (
 		/// <param name="inputPixelBuffer">The input video frame to process.</param>
 		/// <param name="frameOptions">An optional dictionary of options.</param>
 		/// <param name="handler">The callback that will be called when processing is complete.</param>
+		[BindingImpl (BindingImplOptions.Optimizable)]
 		public unsafe VTStatus ProcessFrame (CVPixelBuffer inputPixelBuffer, NSDictionary? frameOptions, VTRawProcessingOutputHandler handler)
 		{
 			delegate* unmanaged<IntPtr, VTStatus, IntPtr, void> trampoline = &VTRawProcessingOutputHandlerCallback;

tests/cecil-tests/BlittablePInvokes.cs

@@ -438,6 +438,9 @@ public void CheckForBlockLiterals ()
 			foreach (var info in Helper.NetPlatformImplementationAssemblyDefinitions) {
 				var assembly = info.Assembly;
 				foreach (var type in assembly.EnumerateTypes ()) {
+					if (type.Is ("ObjCRuntime", "BlockLiteral"))
+						continue;
+
 					foreach (var method in type.EnumerateMethods (m => m.HasBody)) {
 						var body = method.Body;
 						foreach (var instr in body.Instructions) {
@@ -458,14 +461,25 @@ public void CheckForBlockLiterals ()
 							switch (targetMethod.Name) {
 							case "SetupBlock":
 							case "SetupBlockUnsafe":
-								break;
+								var location = method.RenderLocation (instr);
+								var message = $"The call to {targetMethod.Name} in {method.AsFullName ()} must be converted to new Block syntax.";
+								failures [message] = new (message, location);
+								continue;
+							case ".ctor":
+								if (!method.HasBindingImplAttribute (out var bindingImplOptions)) {
+									var loc = method.RenderLocation (body.Instructions.First ());
+									var msg = $"{method.AsFullName ()}: needs [BindingImpl (BindingImplOptions.Optimizable)] because this method creates a BlockLiteral.";
+									failures [msg] = new (msg, loc);
+								} else if ((bindingImplOptions & BindingImplOptions.Optimizable) != BindingImplOptions.Optimizable) {
+									var loc = method.RenderLocation (body.Instructions.First ());
+									var msg = $"{method.AsFullName ()}: has the required [BindingImpl] attribute (because this method creates a BlockLiteral), but the BindingImplOptions.Optimizable flag isn't set.";
+									failures [msg] = new (msg, loc);
+								}
+								continue;
 							default:
 								continue;
 							}
 
-							var location = method.RenderLocation (instr);
-							var message = $"The call to {targetMethod.Name} in {method.AsFullName ()} must be converted to new Block syntax.";
-							failures [message] = new (message, location);
 						}
 					}
 				}
@@ -475,10 +489,6 @@ public void CheckForBlockLiterals ()
 		}
 
 		static HashSet<string> knownFailuresBlockLiterals = new HashSet<string> {
-			"The call to SetupBlock in ObjCRuntime.BlockLiteral.CreateBlockForDelegate(System.Delegate, System.Delegate, System.String) must be converted to new Block syntax.",
-			"The call to SetupBlock in ObjCRuntime.BlockLiteral.GetBlockForDelegate(System.Reflection.MethodInfo, System.Object, System.UInt32, System.String) must be converted to new Block syntax.",
-			"The call to SetupBlock in ObjCRuntime.BlockLiteral.SetupBlock(System.Delegate, System.Delegate) must be converted to new Block syntax.",
-			"The call to SetupBlock in ObjCRuntime.BlockLiteral.SetupBlockUnsafe(System.Delegate, System.Delegate) must be converted to new Block syntax.",
 		};
 
 		[Test]