Skip to content

Commit 69b1556

Browse files
thisisthekaprmarinho
authored andcommitted
Refactored default value handling for ResizeImageInfo.FilterQuality
1 parent fec7d99 commit 69b1556

File tree

5 files changed

+9
-7
lines changed

5 files changed

+9
-7
lines changed

src/SingleProject/Resizetizer/src/ResizeImageInfo.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ namespace Microsoft.Maui.Resizetizer
1010
{
1111
internal class ResizeImageInfo
1212
{
13+
public const SKFilterQuality DefaultFilterQuality = SKFilterQuality.High;
14+
1315
public string? ItemSpec { get; set; }
1416

1517
public string? Alias { get; set; }
@@ -50,7 +52,7 @@ internal class ResizeImageInfo
5052

5153
public double ForegroundScale { get; set; } = 1.0;
5254

53-
public SKFilterQuality? FilterQuality { get; set; }
55+
public SKFilterQuality FilterQuality { get; set; } = DefaultFilterQuality;
5456

5557
private static bool IsVectorFilename(string? filename)
5658
=> IsVectorExtension(Path.GetExtension(filename));

src/SingleProject/Resizetizer/src/SkiaSharpBitmapTools.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public SkiaSharpBitmapTools(ResizeImageInfo info, ILogger logger)
1313
{
1414
}
1515

16-
public SkiaSharpBitmapTools(string filename, SKSize? baseSize, SKColor? backgroundColor, SKColor? tintColor, SKFilterQuality? filterQuality, ILogger logger)
16+
public SkiaSharpBitmapTools(string filename, SKSize? baseSize, SKColor? backgroundColor, SKColor? tintColor, SKFilterQuality filterQuality, ILogger logger)
1717
: base(filename, baseSize, backgroundColor, tintColor, filterQuality, logger)
1818
{
1919
var sw = new Stopwatch();

src/SingleProject/Resizetizer/src/SkiaSharpImaginaryTools.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public SkiaSharpImaginaryTools(ResizeImageInfo info, ILogger logger)
1111
}
1212

1313
public SkiaSharpImaginaryTools(SKColor? backgroundColor, ILogger logger)
14-
: base(null, new SKSize(1, 1), backgroundColor, null, null, logger)
14+
: base(null, new SKSize(1, 1), backgroundColor, null, ResizeImageInfo.DefaultFilterQuality, logger)
1515
{
1616
}
1717

src/SingleProject/Resizetizer/src/SkiaSharpSvgTools.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public SkiaSharpSvgTools(ResizeImageInfo info, ILogger logger)
1414
{
1515
}
1616

17-
public SkiaSharpSvgTools(string filename, SKSize? baseSize, SKColor? backgroundColor, SKColor? tintColor, SKFilterQuality? filterQuality, ILogger logger)
17+
public SkiaSharpSvgTools(string filename, SKSize? baseSize, SKColor? backgroundColor, SKColor? tintColor, SKFilterQuality filterQuality, ILogger logger)
1818
: base(filename, baseSize, backgroundColor, tintColor, filterQuality, logger)
1919
{
2020
var sw = new Stopwatch();

src/SingleProject/Resizetizer/src/SkiaSharpTools.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ static SkiaSharpTools()
1717
span[0] = new SKPoint();
1818
}
1919

20-
public static SkiaSharpTools Create(bool isVector, string filename, SKSize? baseSize, SKColor? backgroundColor, SKColor? tintColor, SKFilterQuality? filterQuality, ILogger logger)
20+
public static SkiaSharpTools Create(bool isVector, string filename, SKSize? baseSize, SKColor? backgroundColor, SKColor? tintColor, SKFilterQuality filterQuality, ILogger logger)
2121
=> isVector
2222
? new SkiaSharpSvgTools(filename, baseSize, backgroundColor, tintColor, filterQuality, logger) as SkiaSharpTools
2323
: new SkiaSharpBitmapTools(filename, baseSize, backgroundColor, tintColor, filterQuality, logger);
@@ -30,15 +30,15 @@ public SkiaSharpTools(ResizeImageInfo info, ILogger logger)
3030
{
3131
}
3232

33-
public SkiaSharpTools(string filename, SKSize? baseSize, SKColor? backgroundColor, SKColor? tintColor, SKFilterQuality? filterQuality, ILogger logger)
33+
public SkiaSharpTools(string filename, SKSize? baseSize, SKColor? backgroundColor, SKColor? tintColor, SKFilterQuality filterQuality, ILogger logger)
3434
{
3535
Logger = logger;
3636
Filename = filename;
3737
BaseSize = baseSize;
3838
BackgroundColor = backgroundColor;
3939
Paint = new SKPaint
4040
{
41-
FilterQuality = filterQuality ?? SKFilterQuality.High
41+
FilterQuality = filterQuality
4242
};
4343

4444
if (tintColor is SKColor tint)

0 commit comments

Comments
 (0)