Skip to content

Add automatic mode for -tl warning summary #11165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rainersigwald opened this issue Dec 17, 2024 · 1 comment
Open

Add automatic mode for -tl warning summary #11165

rainersigwald opened this issue Dec 17, 2024 · 1 comment
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. triaged

Comments

@rainersigwald
Copy link
Member

Continuation of #10681.

We should emit a summary if diagnostics were "long enough ago" in the scroll, as well as having the explicit opt-in/out.

@rainersigwald rainersigwald added the Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. label Dec 17, 2024
@baronfel
Copy link
Member

My proposal for a heuristic:

my ideal state would:

  • know the number of vertical lines available the terminal (we should be able to get this data from a VT control code sequence)
  • if that number is nonzero, estimate the number of lines we've written (NUM_PROJECTS * 1 + SUM(NUM_DIAGNOSTICS_PER_PROJECT)?
  • if that number > TERMINAL_HEIGHT + SOME_PADDING_AMOUNT lines, then emit the summary

all of this would only occur if the summary had not been explicitly requested or disabled by a user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. triaged
Projects
None yet
Development

No branches or pull requests

3 participants