Several changes to reduce allocations #11273
Open
+553
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #11160 |
JanKrivanek
reviewed
Jan 27, 2025
|
Is the plan to split this PR into several smaller ones still in place please? |
…rndt/reduceAllocations
JanKrivanek
reviewed
Feb 4, 2025
| @@ -522,7 +520,7 @@ private void RegisterResolversManifests(ElementLocation location) | |||
| // The collections are never modified after this point. | |||
| // So I've made them ReadOnly | |||
| _specificResolversManifestsRegistry = specificResolversManifestsRegistry.AsReadOnly(); | |||
There was a problem hiding this comment.
Why this AsReadOnly() is left and next one is removed?
There was a problem hiding this comment.
Updated the other one as well.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Curious about thoughts on splitting this PR. I can split it up primarily based on file if that's desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
There is an appreciable amount of time all of the MSBuild process nodes spend doing GC during a build. Taking steps to reduce allocations. This PR contains a mix of approaches that reduce allocations in several areas.
Changes Made
Testing
Notes