[main] Update dependencies from dotnet/arcade - #84740
[main] Update dependencies from dotnet/arcade#84740dotnet-maestro[bot] wants to merge 34 commits into
Conversation
…803.1 On relative base path root Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.XliffTasks From Version 10.0.0-beta.26379.2 -> To Version 11.0.0-beta.26403.1
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Removed the Publish Symbols Dry-Run task from the pipeline.
…803.6 On relative base path root Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.XliffTasks From Version 10.0.0-beta.26379.2 -> To Version 11.0.0-beta.26403.6
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
1d0efec to
149ad05
Compare
….2 On relative base path root Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.XliffTasks From Version 10.0.0-beta.26379.2 -> To Version 11.0.0-beta.26404.2
(cherry picked from commit 2ece8cd) Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
483a308 to
680a51f
Compare
| --> | ||
| <PackageVersion Include="BenchmarkDotNet" Version="0.15.8" /> | ||
| <PackageVersion Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.15.8" /> | ||
| <PackageVersion Include="BenchmarkDotNet" Version="0.16.0-preview.1" /> |
There was a problem hiding this comment.
0.15.8 does not support running on the .NET 11 runtime.
We do use 0.15.8 in the IdeBenchmarks because we are waiting for an updated BenchmarkDotNetDiagnosers package and it does not exercise the GetRuntimeVersion break the other BDN projects hit.
| Write-Host "dotnet $($args -join ' ')" | ||
|
|
||
| & dotnet @args | ||
| $previousRollForward = $env:DOTNET_ROLL_FORWARD |
There was a problem hiding this comment.
This allows us to run IdeBenchmarks on NET 10 while running the others on the NET 11 preview.
| } | ||
|
|
||
| [Fact] | ||
| [Fact(Skip = "https://github.com/dotnet/roslyn/issues/84792")] |
There was a problem hiding this comment.
These test fail when running on .NET 11 runtime
|
|
||
| <!-- Only run validation in CI builds. Running them in local builds will prevent refreshing auto-generated files. --> | ||
| <Exec Command=""$(DotNetExecutable)" --roll-forward major "$(_GenerateRulesMissingDocumentationFilesPath)" "-validateOnly:$(ContinuousIntegrationBuild)" "$(AnalyzerDocumentationFileDir)" "$(ArtifactsBinDir)$(EscapeDirectorySuffix)" "$(Configuration)"" /> | ||
| <Exec EnvironmentVariables="DOTNET_ROLL_FORWARD_TO_PRERELEASE=1" Command=""$(DotNetExecutable)" --roll-forward major "$(_GenerateRulesMissingDocumentationFilesPath)" "-validateOnly:$(ContinuousIntegrationBuild)" "$(AnalyzerDocumentationFileDir)" "$(ArtifactsBinDir)$(EscapeDirectorySuffix)" "$(Configuration)"" /> |
There was a problem hiding this comment.
Some tooling such as GenerateDocumentation and GenerateAnalyzerNuspec need to be configured to rollfoward to prereleases.
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <DefineConstants>$(DefineConstants);ROSLYN_NO_INDEXRANGE</DefineConstants> |
There was a problem hiding this comment.
Newer M.Bcl.Memory brings in its own polyfills
| <Import Project="..\..\Utilities\Compiler\Analyzer.Utilities.projitems" Label="Shared" /> | ||
| <Import Project="..\..\Utilities\Workspaces\Workspaces.Utilities.projitems" Label="Shared" /> | ||
| <ItemGroup> | ||
| <!-- Since this tool will be loading Analyzers built against .NETStandard and the |
| if (!File.Exists(path)) | ||
| { | ||
| await Console.Error.WriteLineAsync($"'{path}' does not exist").ConfigureAwait(false); | ||
| await Console.Error.WriteLineAsync($"'{path}' does not exist".AsMemory(), cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
Initially I moved these projects to target net11. Which brought in new diagnostics about not passing along CancellationToken. However when I switched to setting roll to prerelease I reverted to net10 which did not have an overload that takes (string, CancellationToken)
| @@ -0,0 +1,6 @@ | |||
| <Project> | |||
There was a problem hiding this comment.
Benchmark 0.15.8 generates its own project file in the output folder and if we do not disable transitive pinning for it, will try to use 0.16-preview and tests fail. This gets dropped in the output folder and doesn't affect the rest of the build.
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'net472'"> | ||
| <!-- Exclude the Index and Range implementations since we inherit ones from M.CA.Workspace --> |
There was a problem hiding this comment.
We are already building against Workspaces which has our polyfill for index and range so cannot use a build constant to exclude them, instead we exclude the Bcl.Memory versions.
| - powershell: eng/build.ps1 -configuration Release -prepareMachine -ci -restore -build -pack -publish -sign -binaryLogName Build.binlog /p:DotnetPublishUsingPipelines=true /p:ContinuousIntegrationBuildCorrectness=true | ||
| displayName: Build | ||
|
|
||
| # While this task is not executed in the official build, this serves as a PR check for whether symbol exclusions |
There was a problem hiding this comment.
There is no equivalent in Arcade 11 for validating our symbol exclusions. Will have to rely on test insertions when updating packages that bring in native dependencies
| "dotnet": "11.0.100-preview.6.26359.118", | ||
| "runtimes": { | ||
| "dotnet": [ | ||
| "10.0.10" |
There was a problem hiding this comment.
Needed for IdeBenchmarks. Can remove once we move it to Bdn 0.16
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
Microsoft Reviewers: Open in CodeFlow