Add VS validation requirement for feature branch merges - #84809
Closed
JoeRobich wants to merge 2 commits into
Closed
Add VS validation requirement for feature branch merges#84809JoeRobich wants to merge 2 commits into
JoeRobich wants to merge 2 commits into
Conversation
Added a new requirement for VS validation insertion for feature branch merges and updated existing event responder tasks.
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s GitOps policy configuration to introduce a new event responder task intended to enforce a VS validation insertion requirement for pull requests that merge features/* branches into main.
Changes:
- Added a new
eventResponderTasksrule that requests changes on PR open when the source branch matchesfeatures/*and the target ismain. - Updated the existing policy task list structure to include the new rule (but currently with invalid indentation/trailing whitespace that must be corrected).
Show a summary per file
| File | Description |
|---|---|
| .github/policies/resourceManagement.yml | Adds a new event responder task to block feature-branch-to-main merges unless VS validation insertion requirements are met (needs indentation fix to be valid YAML). |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+47
to
+61
|
|
||
| - description: Require VS validation insertion for feature branch merges | ||
| triggerOnOwnActions: false | ||
| if: | ||
| - payloadType: Pull_Request | ||
| - isPullRequest | ||
| - targetsBranch: | ||
| branch: main | ||
| - sourceBranch: | ||
| branch: features/* | ||
| - isAction: | ||
| action: Opened | ||
| then: | ||
| - requestChangesPullRequest: | ||
| comment: Merges from feature branches require a passing VS validation insertion to complete. |
Contributor
|
Total execution time: 0.01 seconds |
&color=red)
Contributor
|
Total execution time: 0.01 seconds |
Contributor
There was a problem hiding this comment.
Copilot's findings
Suppressed comments (1)
.github/policies/resourceManagement.yml:47
- Line contains whitespace on an otherwise blank separator line. The repo’s style guidance requires blank lines to be completely empty (no spaces/tabs), and whitespace-only lines can cause formatting/lint failures.
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
Member
Author
|
Cancelling as you can't actually filter on the source branch name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new requirement for VS validation insertion for feature branch merges and updated existing event responder tasks.