Registry code cleanup had to be reverted to fix perf tests

[danmoseley]

@JeremyKuhne
dotnet/coreclr#10983

Not sure whether this is necessary for 2.0 or not. Please set milestone to future if not.

@adiaaida supplied repro instructions offline, it seems not to obad so shouldn't take long to narrow down the problem in your change.

[JeremyKuhne]

@adiaaida I assume this is because I stripped out reading perf keys? (Which isn't actually used in CoreLib directly.) Can you provide some details on the failure you were hitting?

[michellemcdaniel]

The failure mode is that when we look at the etl files generated (and subsequently, the any other files that are supposed to have perf data in them), they are empty. This is what @jorive found when he was debugging: "I was debugging the xUnit Performance API, and I noticed on the BenchmarkEventSource (inherits from EventSource), when calling the IsEnabled() method, it always return false."

So basically, because of that, we don't get any of the event data when we run perf with your changes.

[JeremyKuhne]

A repro would be helpful- I might have messed up my changes to EventProvider.GetDataFromController...

[gkhanna79]

@danmosemsft what is the milestone for this?

[JeremyKuhne]

Marked it as future- it was opportunistic.

[dotnet-policy-service]

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

[dotnet-policy-service]

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.