JSSignatureContext.cs may include incorrect use of Math.Abs

[tfenise]

runtime/src/libraries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSSignatureContext.cs

Lines 49 to 58 in 790b14b

	// there could be multiple method signatures with the same name, get unique signature name
	uint hash = 17;
	unchecked
	{
	foreach (var param in sigContext.ElementTypeInformation)
	{
	hash = hash * 31 + (uint)param.ManagedType.FullTypeName.GetHashCode();
	}
	};
	int typesHash = Math.Abs((int)hash);

The last line does not seem correct. If (int)hash == int.MinValue, Math.Abs would throw, which I suppose is not the intended behaviour for a hash function. I would suggest simply int typesHash = (int)hash & int.MaxValue;, or if the hash code is required to be persistent across versions, int typesHash = (int)hash == int.MinValue ? int.MaxValue : Math.Abs((int)hash).

[EgorBo]

It should've used HashCode.Combine but I'm not familiar with what this API does and if the changed hash code impl is a breaking change or not

[pavelsavara]

It doesn't have to be consistent across versions. This just prevents conflict in the names on the same assembly, type and method name.

[dotnet-policy-service]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

[MichalStrehovsky]

The fix was reverted in #110599