Add dotnet pack --no-default-excludes - #55669
Open
cedrikewers wants to merge 1 commit into
Open
Conversation
Packing a .nuspec directly (`dotnet pack MyPackage.nuspec`) bypasses MSBuild and constructs PackArgs by hand in PackCommand.RunPackCommand. NoDefaultExcludes was never set there and no CLI option existed to set it, so files and folders starting with a dot and files ending in .nupkg were always dropped with NU5119 with no way to opt out. Passing -p:NoDefaultExcludes=true has no effect either, because on this path --property values feed nuspec token replacement rather than pack settings. Add a --no-default-excludes option. It is forwarded as -property:NoDefaultExcludes=true so the project-based path continues to flow through NuGet.Build.Tasks.Pack.targets to PackTask, and it is read into PackArgs.NoDefaultExcludes for the nuspec path, so one flag covers both entry points. Also propagate --serviceable and --version-suffix into PackArgs, which were silently dropped on the nuspec path for the same reason. Fixes dotnet#55252 Related: NuGet/Home#15023
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
@dotnet-policy-service agree company="Beckhoff Automation GmbH & Co. KG" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packing a .nuspec directly (
dotnet pack MyPackage.nuspec) bypasses MSBuild and constructs PackArgs by hand in PackCommand.RunPackCommand. NoDefaultExcludes was never set there and no CLI option existed to set it, so files and folders starting with a dot and files ending in .nupkg were always dropped with NU5119 with no way to opt out. Passing-p:NoDefaultExcludes=truehas no effect either, because on this path --property values feed nuspec token replacement rather than pack settings.Add a
--no-default-excludesoption. It is forwarded as-property:NoDefaultExcludes=trueso the project-based path continues to flow through NuGet.Build.Tasks.Pack.targets to PackTask, and it is read into PackArgs.NoDefaultExcludes for the nuspec path, so one flag covers both entry points.Also propagate
--serviceableand--version-suffixinto PackArgs, which were silently dropped on the nuspec path for the same reason.Fixes #55252
Related: NuGet/Home#15023