Added TableExists and FK exists checks

JaBistDuNarrisch · JaBistDuNarrisch · commit 73a409429c15 · 2025-08-18T12:00:59.000+02:00
diff --git a/src/Migrator.Tests/Providers/Base/TransformationProviderSimpleBase.cs b/src/Migrator.Tests/Providers/Base/TransformationProviderSimpleBase.cs
@@ -38,4 +38,9 @@ public void AddTableWithPrimaryKey()
             new Column("bigstring", DbType.String, 50000)
         );
     }
+
+    public void AddPrimaryKey()
+    {
+        Provider.AddPrimaryKey("PK_Test", "Test", "Id");
+    }
 }
diff --git a/src/Migrator.Tests/Providers/Generic/TransformationProviderGenericMiscConstraintBase.cs b/src/Migrator.Tests/Providers/Generic/TransformationProviderGenericMiscConstraintBase.cs
@@ -2,6 +2,8 @@
 using System.Data;
 using System.Linq;
 using DotNetProjects.Migrator.Framework;
+using DotNetProjects.Migrator.Providers.Impl.SQLite;
+using DryIoc;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.Generic;
@@ -113,22 +115,32 @@ public virtual void RemoveCheckConstraint()
     [Test]
     public void RemoveUnexistingForeignKey()
     {
+        // Arrange 
         AddForeignKey();
-        Provider.RemoveForeignKey("abc", "FK_Test_TestTwo");
-        Provider.RemoveForeignKey("abc", "abc");
-        Provider.RemoveForeignKey("Test", "abc");
+
+        // Act/Assert
+        // Table does not exist.
+        Assert.Throws<MigrationException>(() => Provider.RemoveForeignKey("NotExistingTable", "FK_Test_TestTwo"));
+
+        // Table exists but foreign key does not exist.
+        if (Provider is SQLiteTransformationProvider)
+        {
+            Assert.Throws<MigrationException>(() => Provider.RemoveForeignKey("Test", "NotExistingForeignKey"));
+        }
+        else
+        {
+            Assert.That(() => Provider.RemoveForeignKey("Test", "NotExistingForeignKey"), Throws.Exception);
+        }
     }
 
     [Test]
     public void ConstraintExist()
     {
         AddForeignKey();
         Assert.That(Provider.ConstraintExists("TestTwo", "FK_Test_TestTwo"), Is.True);
-        Assert.That(Provider.ConstraintExists("abc", "abc"), Is.False);
+        Assert.That(Provider.ConstraintExists("TestTwo", "abc"), Is.False);
     }
 
-
-
     [Test]
     public void AddTableWithCompoundPrimaryKeyShouldKeepNullForOtherProperties()
     {
diff --git a/src/Migrator.Tests/Providers/OracleProvider/OracleTransformationProvider_PrimaryKeyExists.cs b/src/Migrator.Tests/Providers/OracleProvider/OracleTransformationProvider_PrimaryKeyExists.cs
@@ -0,0 +1,24 @@
+using System.Threading.Tasks;
+using Migrator.Tests.Providers.Base;
+using NUnit.Framework;
+
+namespace Migrator.Tests.Providers.OracleProvider;
+
+[TestFixture]
+[Category("Oracle")]
+public class OracleTransformationProvider_PrimaryKeyExistsTests : TransformationProviderSimpleBase
+{
+    [SetUp]
+    public async Task SetUpAsync()
+    {
+        await BeginOracleTransactionAsync();
+    }
+
+    [Test]
+    public void CanAddPrimaryKey()
+    {
+        AddTable();
+        AddPrimaryKey();
+        Assert.That(Provider.PrimaryKeyExists("Test", "PK_Test"), Is.True);
+    }
+}
diff --git a/src/Migrator.Tests/Providers/PostgreSQL/Base/PostgreSQLTransformationProviderTestBase.cs b/src/Migrator.Tests/Providers/PostgreSQL/Base/PostgreSQLTransformationProviderTestBase.cs
@@ -1,33 +1,16 @@
-using DotNetProjects.Migrator.Providers;
-using DotNetProjects.Migrator.Providers.Impl.PostgreSQL;
+using System.Threading.Tasks;
 using Migrator.Tests.Providers.Base;
-using Migrator.Tests.Settings;
-using Migrator.Tests.Settings.Config;
 using NUnit.Framework;
 
-namespace Migrator.Tests.Providers.PostgreSQL;
+namespace Migrator.Tests.Providers.PostgreSQL.Base;
 
 [TestFixture]
 [Category("Postgre")]
 public abstract class PostgreSQLTransformationProviderTestBase : TransformationProviderSimpleBase
 {
     [SetUp]
-    public void SetUp()
+    public async Task SetUpAsync()
     {
-        var configReader = new ConfigurationReader();
-        var connectionString = configReader.GetDatabaseConnectionConfigById(DatabaseConnectionConfigIds.PostgreSQL)
-            ?.ConnectionString;
-
-        if (string.IsNullOrEmpty(connectionString))
-        {
-            throw new IgnoreException("No Postgre ConnectionString is Set.");
-        }
-
-        DbProviderFactories.RegisterFactory("Npgsql", () => Npgsql.NpgsqlFactory.Instance);
-
-        Provider = new PostgreSQLTransformationProvider(new PostgreSQLDialect(), connectionString, null, "default", "Npgsql");
-        Provider.BeginTransaction();
-
-        AddDefaultTable();
+        await BeginPostgreSQLTransactionAsync();
     }
 }
diff --git a/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_AddTableTests.cs b/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_AddTableTests.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Data;
 using DotNetProjects.Migrator.Framework;
+using Migrator.Tests.Providers.PostgreSQL.Base;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.PostgreSQL;
diff --git a/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_GetColumnContent_SizeTests.cs b/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_GetColumnContent_SizeTests.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Data;
 using DotNetProjects.Migrator.Framework;
+using Migrator.Tests.Providers.PostgreSQL.Base;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.PostgreSQL;
diff --git a/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_GetColumnsTypeTests.cs b/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_GetColumnsTypeTests.cs
@@ -1,6 +1,7 @@
 using System.Data;
 using System.Linq;
 using DotNetProjects.Migrator.Framework;
+using Migrator.Tests.Providers.PostgreSQL.Base;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.PostgreSQL;
diff --git a/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_PrimaryKeyExistsTests.cs b/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_PrimaryKeyExistsTests.cs
@@ -0,0 +1,20 @@
+using System.Data;
+using System.Linq;
+using DotNetProjects.Migrator.Framework;
+using Migrator.Tests.Providers.PostgreSQL.Base;
+using NUnit.Framework;
+
+namespace Migrator.Tests.Providers.PostgreSQL;
+
+[TestFixture]
+[Category("Postgre")]
+public class PostgreSQLTransformationProvider_PrimaryKeyExistsTests : PostgreSQLTransformationProviderTestBase
+{
+    [Test]
+    public void CanAddPrimaryKey()
+    {
+        AddTable();
+        AddPrimaryKey();
+        Assert.That(Provider.PrimaryKeyExists("Test", "PK_Test"), Is.True);
+    }
+}
diff --git a/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_PrimaryKeyWithIdentityTests.cs b/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_PrimaryKeyWithIdentityTests.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Data;
 using DotNetProjects.Migrator.Framework;
+using Migrator.Tests.Providers.PostgreSQL.Base;
 using Npgsql;
 using NUnit.Framework;
 
diff --git a/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_TableExistsTests.cs b/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_TableExistsTests.cs
@@ -1,5 +1,6 @@
 using System.Data;
 using DotNetProjects.Migrator.Framework;
+using Migrator.Tests.Providers.PostgreSQL.Base;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.PostgreSQL;
diff --git a/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_ViewExistsTests.cs b/src/Migrator.Tests/Providers/PostgreSQL/PostgreSQLTransformationProvider_ViewExistsTests.cs
@@ -1,5 +1,6 @@
 using System.Data;
 using DotNetProjects.Migrator.Framework;
+using Migrator.Tests.Providers.PostgreSQL.Base;
 using NUnit.Framework;
 
 namespace Migrator.Tests.Providers.PostgreSQL;
diff --git a/src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_AddTableTests.cs b/src/Migrator.Tests/Providers/SQLite/SQLiteTransformationProvider_AddTableTests.cs
@@ -25,7 +25,9 @@ public void AddTable_UniqueOnly_ContainsNull()
         Assert.That("CREATE TABLE MyTableName (MyColumnName INTEGER NULL UNIQUE)", Is.EqualTo(createScript));
 
         var sqliteInfo = ((SQLiteTransformationProvider)Provider).GetSQLiteTableInfo(tableName);
-        Assert.That(sqliteInfo.Uniques.Single().KeyColumns.Single(), Is.EqualTo(columnName));
+
+        // It is no named unique so it is not listed in the Uniques list. Unique on column level is marked as obsolete.
+        Assert.That(sqliteInfo.Uniques, Is.Empty);
     }
 
     [Test]
diff --git a/src/Migrator/Providers/Impl/SQLite/SQLiteTransformationProvider.cs b/src/Migrator/Providers/Impl/SQLite/SQLiteTransformationProvider.cs
@@ -341,7 +341,17 @@ public DbType ExtractTypeFromColumnDef(string columnDef)
 
     public override void RemoveForeignKey(string table, string name)
     {
+        if (!TableExists(table))
+        {
+            throw new MigrationException($"Table '{table}' does not exist.");
+        }
+
         var sqliteTableInfo = GetSQLiteTableInfo(table);
+        if (!sqliteTableInfo.ForeignKeys.Any(x => x.Name.Equals(name, StringComparison.OrdinalIgnoreCase)))
+        {
+            throw new MigrationException($"Foreign key '{name}' does not exist.");
+        }
+
         sqliteTableInfo.ForeignKeys.RemoveAll(x => x.Name.Equals(name, StringComparison.OrdinalIgnoreCase));
 
         RecreateTable(sqliteTableInfo);
@@ -642,6 +652,11 @@ public override void AddPrimaryKey(string name, string tableName, params string[
         RecreateTable(sqliteTableInfo);
     }
 
+    public override bool PrimaryKeyExists(string table, string name)
+    {
+        throw new NotSupportedException($"SQLite does not support named primary keys. You may wonder why there is a name in method '{nameof(AddPrimaryKey)}'. It is because of architectural decisions of the past. It is overridden in {nameof(SQLiteTransformationProvider)}.");
+    }
+
     public override void AddUniqueConstraint(string name, string table, params string[] columns)
     {
         var sqliteTableInfo = GetSQLiteTableInfo(table);
diff --git a/src/Migrator/Providers/TransformationProvider.cs b/src/Migrator/Providers/TransformationProvider.cs
@@ -269,15 +269,27 @@ public virtual string[] GetTables()
 
     public virtual void RemoveForeignKey(string table, string name)
     {
+        if (!TableExists(table))
+        {
+            throw new MigrationException($"Table '{table}' does not exist.");
+        }
+
         RemoveConstraint(table, name);
     }
 
     public virtual void RemoveConstraint(string table, string name)
     {
-        if (TableExists(table) && ConstraintExists(table, name))
+        if (!TableExists(table))
         {
-            ExecuteNonQuery(string.Format("ALTER TABLE {0} DROP CONSTRAINT {1}", QuoteTableNameIfRequired(table), QuoteConstraintNameIfRequired(name)));
+            throw new MigrationException($"Table '{name}' does not exist");
         }
+
+        if (!ConstraintExists(table, name))
+        {
+            throw new MigrationException($"Constraint '{name}' does not exist");
+        }
+
+        ExecuteNonQuery(string.Format("ALTER TABLE {0} DROP CONSTRAINT {1}", QuoteTableNameIfRequired(table), QuoteConstraintNameIfRequired(name)));
     }
 
     public virtual void RemoveAllConstraints(string table)

Original file line number	Diff line number	Diff line change
`@@ -38,4 +38,9 @@ public void AddTableWithPrimaryKey()`
`38`	`38`	`new Column("bigstring", DbType.String, 50000)`
`39`	`39`	`);`
`40`	`40`	`}`
	`41`	`+`
	`42`	`+ public void AddPrimaryKey()`
	`43`	`+ {`
	`44`	`+ Provider.AddPrimaryKey("PK_Test", "Test", "Id");`
	`45`	`+ }`
`41`	`46`	`}`