Merge pull request #116 from dotnetprojects/sql-server-default-values

Added byte to default values in SQL Server

Author: JaBistDuNarrisch

src/Migrator.Tests/Providers/SQLServer/SQLServerTransformationProvider_GetColumns_DefaultValues_Tests.cs

@@ -0,0 +1,93 @@
+using System;
+using System.Data;
+using System.Linq;
+using System.Runtime.CompilerServices;
+using System.Threading.Tasks;
+using DotNetProjects.Migrator.Framework;
+using Migrator.Tests.Providers.Base;
+using NUnit.Framework;
+
+namespace Migrator.Tests.Providers.SQLServer;
+
+[TestFixture]
+[Category("SqlServer")]
+public class SQLServerTransformationProvider_GetColumns_DefaultValues_Tests : TransformationProviderBase
+{
+    [SetUp]
+    public async Task SetUpAsync()
+    {
+        await BeginSQLServerTransactionAsync();
+    }
+
+    [Test]
+    public void GetColumns_DefaultValues_Succeeds()
+    {
+        // Arrange
+        var dateTimeDefaultValue = new DateTime(2000, 1, 2, 3, 4, 5, DateTimeKind.Utc);
+        var guidDefaultValue = Guid.NewGuid();
+        var decimalDefaultValue = 14.56565m;
+
+        const string testTableName = "MyDefaultTestTable";
+
+        const string dateTimeColumnName1 = "datetimecolumn1";
+        const string dateTimeColumnName2 = "datetimecolumn2";
+        const string decimalColumnName1 = "decimalcolumn";
+        const string guidColumnName1 = "guidcolumn1";
+        const string booleanColumnName1 = "booleancolumn1";
+        const string int32ColumnName1 = "int32column1";
+        const string int64ColumnName1 = "int64column1";
+        const string int64ColumnName2 = "int64column2";
+        const string stringColumnName1 = "stringcolumn1";
+        const string binaryColumnName1 = "binarycolumn1";
+        const string doubleColumnName1 = "doublecolumn1";
+        const string byteColumnName1 = "byteColumn1";
+
+        // Should be extended by remaining types
+        Provider.AddTable(testTableName,
+            new Column(dateTimeColumnName1, DbType.DateTime, dateTimeDefaultValue),
+            new Column(dateTimeColumnName2, DbType.DateTime2, dateTimeDefaultValue),
+            new Column(decimalColumnName1, DbType.Decimal, decimalDefaultValue),
+            new Column(guidColumnName1, DbType.Guid, guidDefaultValue),
+
+            // other boolean default values are tested in another test
+            new Column(booleanColumnName1, DbType.Boolean, true),
+
+            new Column(int32ColumnName1, DbType.Int32, defaultValue: 43),
+            new Column(int64ColumnName1, DbType.Int64, defaultValue: 88),
+            new Column(int64ColumnName2, DbType.Int64, defaultValue: 0),
+            new Column(stringColumnName1, DbType.String, defaultValue: "Hello"),
+            new Column(binaryColumnName1, DbType.Binary, defaultValue: new byte[] { 12, 32, 34 }),
+            new Column(doubleColumnName1, DbType.Double, defaultValue: 84.874596567) { Precision = 19, Scale = 10 },
+            new Column(byteColumnName1, DbType.Byte, defaultValue: 233)
+        );
+
+        // Act
+        var columns = Provider.GetColumns(testTableName);
+
+        // Assert
+        var dateTimeColumn1 = columns.Single(x => x.Name.Equals(dateTimeColumnName1, StringComparison.OrdinalIgnoreCase));
+        var dateTimeColumn2 = columns.Single(x => x.Name.Equals(dateTimeColumnName2, StringComparison.OrdinalIgnoreCase));
+        var decimalColumn1 = columns.Single(x => x.Name.Equals(decimalColumnName1, StringComparison.OrdinalIgnoreCase));
+        var guidColumn1 = columns.Single(x => x.Name.Equals(guidColumnName1, StringComparison.OrdinalIgnoreCase));
+        var booleanColumn1 = columns.Single(x => x.Name.Equals(booleanColumnName1, StringComparison.OrdinalIgnoreCase));
+        var int32Column1 = columns.Single(x => x.Name.Equals(int32ColumnName1, StringComparison.OrdinalIgnoreCase));
+        var int64Column1 = columns.Single(x => x.Name.Equals(int64ColumnName1, StringComparison.OrdinalIgnoreCase));
+        var int64Column2 = columns.Single(x => x.Name.Equals(int64ColumnName2, StringComparison.OrdinalIgnoreCase));
+        var stringColumn1 = columns.Single(x => x.Name.Equals(stringColumnName1, StringComparison.OrdinalIgnoreCase));
+        var binarycolumn1 = columns.Single(x => x.Name.Equals(binaryColumnName1, StringComparison.OrdinalIgnoreCase));
+        var doubleColumn1 = columns.Single(x => x.Name.Equals(doubleColumnName1, StringComparison.OrdinalIgnoreCase));
+        var byteColumn1 = columns.Single(x => x.Name.Equals(byteColumnName1, StringComparison.OrdinalIgnoreCase));
+
+        Assert.That(dateTimeColumn1.DefaultValue, Is.EqualTo(dateTimeDefaultValue));
+        Assert.That(dateTimeColumn2.DefaultValue, Is.EqualTo(dateTimeDefaultValue));
+        Assert.That(decimalColumn1.DefaultValue, Is.EqualTo(decimalDefaultValue));
+        Assert.That(guidColumn1.DefaultValue, Is.EqualTo(guidDefaultValue));
+        Assert.That(booleanColumn1.DefaultValue, Is.True);
+        Assert.That(int32Column1.DefaultValue, Is.EqualTo(43));
+        Assert.That(int64Column1.DefaultValue, Is.EqualTo(88));
+        Assert.That(stringColumn1.DefaultValue, Is.EqualTo("Hello"));
+        Assert.That(binarycolumn1.DefaultValue, Is.EqualTo(new byte[] { 12, 32, 34 }));
+        Assert.That(doubleColumn1.DefaultValue, Is.EqualTo(84.874596567));
+        Assert.That(byteColumn1.DefaultValue, Is.EqualTo(233));
+    }
+}

src/Migrator/Providers/Impl/SqlServer/SqlServerTransformationProvider.cs

@@ -544,6 +544,10 @@ public override Column[] GetColumns(string table)
                             throw new NotImplementedException($"Cannot parse the binary default value of '{column.Name}'. The value is '{defaultValueString}'");
                         }
                     }
+                    else if (column.MigratorDbType == MigratorDbType.Byte)
+                    {
+                        column.DefaultValue = byte.Parse(bracesStrippedString);
+                    }
                     else
                     {
                         throw new NotImplementedException($"Cannot parse the default value of {column.Name} type '{column.MigratorDbType}'. It is not yet implemented - file an issue.");