Skip to content

Commit 77baa53

Browse files
committed
chore: aggiunti TODO esercizio 5
1 parent 61b79d2 commit 77baa53

File tree

5 files changed

+20
-8
lines changed

5 files changed

+20
-8
lines changed

03_driver_reactive/src/test/java/io/doubleloop/driverreactive/DependencyRulesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import org.junit.jupiter.api.Disabled;
77
import org.junit.jupiter.api.Test;
88

9-
@Disabled("Run after moving classes into various packages")
9+
@Disabled
1010
class DependencyRulesTest {
1111

1212
private final JavaClasses classes = new ClassFileImporter().importPackages(DependencyRulesTest.class.getPackageName());

04_driven_pull/src/test/java/io/doubleloop/drivenpull/DependencyRulesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import org.junit.jupiter.api.Disabled;
77
import org.junit.jupiter.api.Test;
88

9-
@Disabled("Run after moving classes into various packages")
9+
@Disabled
1010
class DependencyRulesTest {
1111

1212
private final JavaClasses classes = new ClassFileImporter().importPackages(DependencyRulesTest.class.getPackageName());

05_driven_push/TODO.md

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,15 @@
11
## TODO:
2-
- [ ] rinomina le classi infrastrutturali
3-
- [ ] estrai le interfacce usando nome di dominio
4-
- [ ] elimina l'uso di mongodb e del vero repository dalla suite DefaultDailyBalanceServiceTest
5-
- [ ] sposta classi e interfacce nelle rispettive cartelle
2+
3+
- [ ] Leggi il codice di [DefaultPostService](src/main/java/io/doubleloop/drivenpush/DefaultPostService.java).
4+
- [ ] Aggiungi una nuova classe infrastrutturale `SpringRabbitMqPostNotifier` con il codice relativo alla pubblicazione
5+
di `PostMessageCommand` preso da [DefaultPostService](src/main/java/io/doubleloop/drivenpush/DefaultPostService.java)
6+
- [ ] Utilizza `SpringRabbitMqPostNotifier`
7+
in [DefaultPostService](src/main/java/io/doubleloop/drivenpush/DefaultPostService.java) al posto di `RabbitTemplate` e
8+
`Jsonb`.
9+
- [ ] Estrai un'interfaccia `PostNotifier`.
10+
- [ ] Utilizza `PostNotifier` in [DefaultPostService](src/main/java/io/doubleloop/drivenpush/DefaultPostService.java) al
11+
posto di `SpringRabbitMqPostNotifier`.
12+
- [ ] Sposta i file nei rispettivi package/folder in base alla responsabilità.
13+
- [ ] Rimuovi l'annotazione `@Disabled`
14+
da [DependencyRulesTest](src/test/java/io/doubleloop/drivenpush/DependencyRulesTest.java#L9) e
15+
verifica che i test siano verdi.

05_driven_push/src/main/java/io/doubleloop/drivenpush/DefaultPostService.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,13 @@ public void postMessage(PostMessageCommand command) {
2626
if (found.isEmpty()) {
2727
throw new IllegalArgumentException("User not found");
2828
}
29+
2930
final var user = found.get();
3031
if (user.isBlocked()) {
3132
throw new IllegalArgumentException("User is blocked");
3233
}
3334

34-
rabbitTemplate.convertAndSend(exchangeName, "posts.%s.new".formatted(command.getUserId()), jsonb.toJson(command));
35+
final var message = jsonb.toJson(command);
36+
rabbitTemplate.convertAndSend(exchangeName, "posts.%s.new".formatted(command.getUserId()), message);
3537
}
3638
}

05_driven_push/src/test/java/io/doubleloop/drivenpush/DependencyRulesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import org.junit.jupiter.api.Disabled;
77
import org.junit.jupiter.api.Test;
88

9-
@Disabled("Run after moving classes into various packages")
9+
@Disabled
1010
class DependencyRulesTest {
1111

1212
private final JavaClasses classes = new ClassFileImporter().importPackages(DependencyRulesTest.class.getPackageName());

0 commit comments

Comments
 (0)