chore: aggiungti system test per esercizio 0

Author: matteobaglini

00_problems/pom.xml

@@ -18,9 +18,21 @@
       <artifactId>spring-boot-starter-web</artifactId>
     </dependency>
     <dependency>
-      <groupId>jakarta.mail</groupId>
-      <artifactId>jakarta.mail-api</artifactId>
-      <version>2.1.3</version>
+      <groupId>com.sun.mail</groupId>
+      <artifactId>jakarta.mail</artifactId>
+      <version>2.0.1</version>
+    </dependency>
+
+    <dependency>
+      <groupId>org.springframework.boot</groupId>
+      <artifactId>spring-boot-starter-test</artifactId>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>com.icegreen</groupId>
+      <artifactId>greenmail</artifactId>
+      <version>2.0.1</version>
+      <scope>test</scope>
     </dependency>
   </dependencies>
 

00_problems/src/main/java/io/doubleloop/problems/BirthdayController.java

@@ -1,7 +1,6 @@
 package io.doubleloop.problems;
 
 import jakarta.mail.MessagingException;
-import org.springframework.beans.factory.annotation.Value;
 import org.springframework.format.annotation.DateTimeFormat;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.PostMapping;
@@ -16,29 +15,15 @@
 public class BirthdayController {
 
   private final BirthdayService service;
-  private final String filePath;
-  private final String smtpHost;
-  private final int smtpPort;
-
-  public BirthdayController(BirthdayService service,
-                            @Value("${app.employee.file}") String filePath,
-                            @Value("${app.smtp.host}") String smtpHost,
-                            @Value("${app.smtp.port}") int smtpPort) {
+
+  public BirthdayController(BirthdayService service) {
     this.service = service;
-    this.filePath = filePath;
-    this.smtpHost = smtpHost;
-    this.smtpPort = smtpPort;
   }
 
   @PostMapping("/sendGreetings")
   public ResponseEntity<Void> send(@DateTimeFormat(iso = DateTimeFormat.ISO.DATE) LocalDate date) throws MessagingException, IOException {
 
-    service.sendGreetings(
-        filePath,
-        getValueOrDefault(date),
-        smtpHost,
-        smtpPort
-    );
+    service.sendGreetings(getValueOrDefault(date));
 
     return ResponseEntity.ok().build();
   }

00_problems/src/main/java/io/doubleloop/problems/BirthdayService.java

@@ -6,17 +6,31 @@
 import jakarta.mail.Transport;
 import jakarta.mail.internet.InternetAddress;
 import jakarta.mail.internet.MimeMessage;
-import org.springframework.stereotype.Service;
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.stereotype.Component;
 
 import java.io.BufferedReader;
 import java.io.FileReader;
 import java.io.IOException;
 import java.time.LocalDate;
 import java.util.Properties;
 
-@Service
+@Component
 public class BirthdayService {
-  public void sendGreetings(String filePath, LocalDate today, String smtpHost, int smtpPort) throws IOException, MessagingException {
+
+  private final String filePath;
+  private final String smtpHost;
+  private final int smtpPort;
+
+  public BirthdayService(@Value("${app.employee.file}") String filePath,
+                         @Value("${app.smtp.host}") String smtpHost,
+                         @Value("${app.smtp.port}") int smtpPort) {
+    this.filePath = filePath;
+    this.smtpHost = smtpHost;
+    this.smtpPort = smtpPort;
+  }
+
+  public void sendGreetings(LocalDate today) throws IOException, MessagingException {
     BufferedReader in = new BufferedReader(new FileReader(filePath));
     String str = "";
     str = in.readLine(); // skip header
@@ -27,26 +41,23 @@ public void sendGreetings(String filePath, LocalDate today, String smtpHost, int
         String recipient = employee.getEmail();
         String body = "Happy Birthday, dear %NAME%".replace("%NAME%", employee.getFirstName());
         String subject = "Happy Birthday!";
-        sendMessage(smtpHost, smtpPort, "[email protected]", subject, body, recipient);
+        sendMessage("[email protected]", subject, body, recipient);
       }
     }
   }
 
-  private void sendMessage(String smtpHost, int smtpPort, String sender, String subject, String body, String recipient) throws MessagingException {
-    // Create a mail session
+  private void sendMessage(String sender, String subject, String body, String recipient) throws MessagingException {
     Properties props = new Properties();
     props.put("mail.smtp.host", smtpHost);
     props.put("mail.smtp.port", String.valueOf(smtpPort));
     Session session = Session.getInstance(props, null);
 
-    // Construct the message
     Message msg = new MimeMessage(session);
     msg.setFrom(new InternetAddress(sender));
     msg.setRecipient(Message.RecipientType.TO, new InternetAddress(recipient));
     msg.setSubject(subject);
     msg.setText(body);
 
-    // Send the message
     Transport.send(msg);
   }
 }

00_problems/src/test/java/io/doubleloop/problems/BirthdayServiceTest.java

@@ -0,0 +1,51 @@
+package io.doubleloop.problems;
+
+import com.icegreen.greenmail.util.GreenMail;
+import com.icegreen.greenmail.util.ServerSetup;
+import jakarta.mail.Message;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.time.LocalDate;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+class BirthdayServiceTest {
+
+  private String filePath;
+  private String smtpHost = "localhost";
+  private int smtpPort = 3025;
+  private GreenMail mailServer;
+
+  @BeforeEach
+  void setUp() {
+    filePath = getClass()
+        .getClassLoader()
+        .getResource("employee_data.txt")
+        .getPath();
+
+    mailServer = new GreenMail(new ServerSetup(smtpPort, null, "smtp"));
+    mailServer.start();
+  }
+
+  @AfterEach
+  void tearDown() {
+    mailServer.stop();
+  }
+
+  @Test
+  void testSendMessage() throws Exception {
+    final var emailService = new BirthdayService(filePath, smtpHost, smtpPort);
+    emailService.sendGreetings(LocalDate.of(2024, 10, 8));
+
+    final var receivedMessages = mailServer.getReceivedMessages();
+    assertEquals(1, receivedMessages.length);
+
+    final var receivedMessage = receivedMessages[0];
+    assertEquals("Happy Birthday!", receivedMessage.getSubject());
+    assertEquals("Happy Birthday, dear John", receivedMessage.getContent().toString());
+    assertEquals("[email protected]", receivedMessage.getFrom()[0].toString());
+    assertEquals("[email protected]", receivedMessage.getRecipients(Message.RecipientType.TO)[0].toString());
+  }
+}

00_problems/src/test/resources/employee_data.txt

@@ -0,0 +1,3 @@
+last_name, first_name, date_of_birth, email
+Doe, John, 1982/10/08, [email protected]
+Ann, Mary, 1975/03/11, [email protected]