Unable to retrieve company list if response contains a company with a Null integrations value.

[keithmangan]

Describe the bug
Unable to return a list of Companies Getting error "Response could not be deserialized to JSON"
Here is a a copy of the inner stack trace I think is relevant to the bug.

 System.AggregateException: One or more errors occurred. (Response could not be deserialized to JSON: GET https://RemovedURL/api/v1/companies?page=1)
 ---> Flurl.Http.FlurlParsingException: Response could not be deserialized to JSON: GET https:///RemovedURL/api/v1/companies?page=1
 ---> Newtonsoft.Json.JsonSerializationException: Error converting value {null} to type 'System.Int32'. Path 'companies[1].integrations[0].sync_id', line 1, position 1752.
 ---> System.InvalidCastException: Null object cannot be converted to a value type.
   at System.Convert.ChangeType(Object value, Type conversionType, IFormatProvider provider)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.EnsureType(JsonReader reader, Object value, CultureInfo culture, JsonContract contract, Type targetType)
   --- End of inner exception stack trace ---

To Reproduce
Steps to reproduce the behavior:
I just did a very simple test of Get Companies Method only passing the parameter of page 1.
I think the issue is when there is a company in the result set with a Null integrations dataset.

Expected behavior
The Get Companies Method should Return the First page of companies when passing the parameter page with a value of 1

Desktop (please complete the following information):

• OS: Windows server 2019

[dracon80]

Any chance you can provide a sanitized copy of the JSON you get when you query https://RemovedURL/api/v1/companies?page=1.
My test system and the integrations are either an empty array, or have a value in the id field.

[keithmangan]

json example.txt
Attached is a txt with the json for the first two Companies returned on page 1. I removed all sensitive strings by replacing the text with REMOVED.
The first company in the list contains an integrations value while the second does not. If you need more I can include more on the list. Just didn't want to go through all companies on the first page.

[dracon80]

Thanks, I'll have a look tonight after work and see what I can do.

[dracon80]

Sorry it took so long, came down sick.
I've modified the sync_id and identifier to use a string instead of int. My basic tests are passing but I have no integrations that are returning data the same as yours.
Can you please test out this pre-lease from the branch I created for this issue.
https://github.com/dracon80/CSharp-HuduAPI-Client/releases/download/v1.0.6-pre-release/Hudu-APIClient.1.0.6.nupkg

If it works as expected I'll update the master branch and publish it.

[dracon80]

@keithmangan did you get a chance to test it out?

[keithmangan]

Just tested it out. Figured out that I was wrong in my first error report. It is still throwing an error, but only on companies that return an integration where the sync_id is null. We use Datto RMM and that is using the identifier value (string) instead of the sync_id (int), so sync_id is always returned null. We also have integration with Connectwise Manage. That uses the sync_id but the identifier variable is returned null in that instance.
Error is System.AggregateException: One or more errors occurred. (Response could not be deserialized to JSON: GET https://URLRemoved/api/v1/companies?page=1) ---> Flurl.Http.FlurlParsingException: Response could not be deserialized to JSON: GET https://URLREmoved/api/v1/companies?page=1 ---> Newtonsoft.Json.JsonSerializationException: Error converting value {null} to type 'System.Int32'. Path 'companies[0].integrations[0].sync_id', line 1, position 1008..

[dracon80]

@keithmangan I've updated the code a little again to allow null values both both of these properties.
Can you try using the following nuget package to see if it fixes the problem for you.
https://github.com/dracon80/CSharp-HuduAPI-Client/releases/download/v1.0.6-pre-release/Hudu-APIClient.1.0.6.nupkg

[keithmangan]

So I am getting the same error. I removed the previous test version, and downloaded the one you provided in the last reply and installed that nuget package.
I have attached the full exception page I am getting along with a JSON result I get when sending a REST API call manually.

The code I am running is pretty simple to test it. I am just calling a test company called uptimeLab that returns a company with an integration that has a null sync_id variable (see json file)
This does work if I change the name param to a company that has no integration

CompaniesEndpoint companiesEP = new CompaniesEndpoint(apiKey, apiUrl);
GetCompanies companiesParams = new GetCompanies();
 companiesParams.Page = 1;
companiesParams.Name = "Uptime Lab";
var compList = companiesEP.Get(companiesParams);

files.zip