From c3f9ec18ae304895f7aca3fd35f8ced3f9964342 Mon Sep 17 00:00:00 2001 From: Shahar Mike Date: Tue, 15 Oct 2024 14:48:32 +0300 Subject: [PATCH] fix: Fix `test_flushall_in_full_sync` (#3929) * fix: Fix `test_flushall_in_full_sync` This test failed in CI many times. The issue was that we reach stable sync too quickly, and miss the full sync stage. I changed the seeder to add 100k (instead of 30k) keys for the stage to take longer. * StaticSeeder --- tests/dragonfly/replication_test.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/dragonfly/replication_test.py b/tests/dragonfly/replication_test.py index 30d3672c0ccf..3533e8f709b9 100644 --- a/tests/dragonfly/replication_test.py +++ b/tests/dragonfly/replication_test.py @@ -17,6 +17,7 @@ from .seeder import Seeder as SeederV2 from . import dfly_args from .proxy import Proxy +from .seeder import StaticSeeder ADMIN_PORT = 1211 @@ -1107,8 +1108,8 @@ async def test_flushall_in_full_sync(df_factory): c_replica = replica.client() # Fill master with test data - seeder = SeederV2(key_target=30_000) - await seeder.run(c_master, target_deviation=0.1) + seeder = StaticSeeder(key_target=100_000) + await seeder.run(c_master) # Start replication and wait for full sync await c_replica.execute_command(f"REPLICAOF localhost {master.port}")