Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster migration test in cache mode #4354

Open
chakaz opened this issue Dec 23, 2024 · 2 comments · Fixed by #4413 · May be fixed by #4435
Open

Add cluster migration test in cache mode #4354

chakaz opened this issue Dec 23, 2024 · 2 comments · Fixed by #4413 · May be fixed by #4435
Assignees

Comments

@chakaz
Copy link
Collaborator

chakaz commented Dec 23, 2024

          This last comment makes me think that we are missing cluster migration test for dragonfly running in cache mode and for testing expire logic. Lets open a separate task for that and do this in a separate PR

Originally posted by @adiholden in #4197 (comment)

@BorysTheDev
Copy link
Contributor

BorysTheDev commented Jan 8, 2025

@adiholden Could you clarify what stats check we want to verify regarding expiration? Because we use up to 0.5s expiration time in seeder and in the end of migration process the all keys are expired

@adiholden
Copy link
Collaborator

Checkout test_expiry in replication test.
To make sure expire runs at the time of migration run the expire commands only after you start migration.
You will need to check the info stats to see the source node expired some keys to make sure that some keys are expired at the time of migration

@BorysTheDev BorysTheDev linked a pull request Jan 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants