Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special Redis commands can cause the Dragonfly service to crash #4466

Closed
ankki-zsyang opened this issue Jan 17, 2025 · 1 comment · Fixed by #4500
Closed

Special Redis commands can cause the Dragonfly service to crash #4466

ankki-zsyang opened this issue Jan 17, 2025 · 1 comment · Fixed by #4500
Assignees
Labels
bug Something isn't working

Comments

@ankki-zsyang
Copy link

Summary

Authenticated users can construct specific commands that cause the dragonfly service to crash.

Details

Dragonfly version: df-v1.26.1
Payload:
SCAN 9223372036854775808 MATCH *11*
Executing the above payload will cause the dragonfly service to crash immediately.
Poof:

Image

Image

Reporter

The problem was reported by ankki-zsyang, Shenzhen Ankki Technologies Co.Ltd.

@ankki-zsyang ankki-zsyang added the bug Something isn't working label Jan 17, 2025
@kostasrim
Copy link
Contributor

Hi @ankki-zsyang ,

Thank you for reporting this! We will take a look :)

@romange romange self-assigned this Jan 24, 2025
romange added a commit that referenced this issue Jan 24, 2025
1. Fixes #4466 (we did not check validity of the scan cursor)
   We fix it by quietly returning "end of scan" result, i.e. no error are returned.
2. Add 34b1048274c8e50a0cc587a3ed9c383a82bb78c5 sha to the lua_undeclared_keys_shas list.
3. Pull helio that fixes bugs with WaitQueue and IdleTasks: romange/helio@2ab4412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants