Skip to content

Commit ed9d547

Browse files
committed
Update relationship naming convention(#331)
1 parent e6a36cd commit ed9d547

File tree

7 files changed

+29
-17
lines changed

7 files changed

+29
-17
lines changed

Diff for: src/components/EditorCanvas/Canvas.jsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -431,9 +431,9 @@ export default function Canvas() {
431431
cardinality: Cardinality.ONE_TO_ONE,
432432
updateConstraint: Constraint.NONE,
433433
deleteConstraint: Constraint.NONE,
434-
name: `${tables[linkingLine.startTableId].name}_${
434+
name: `fk_${tables[linkingLine.startTableId].name}_${
435435
tables[linkingLine.startTableId].fields[linkingLine.startFieldId].name
436-
}_fk`,
436+
}_${tables[hoveredTable.tableId].name}`,
437437
id: relationships.length,
438438
};
439439
delete newRelationship.startX;

Diff for: src/components/EditorSidePanel/RelationshipsTab/RelationshipInfo.jsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@ export default function RelationshipInfo({ data }) {
6161
idx === data.id
6262
? {
6363
...e,
64-
name: `${tables[e.startTableId].name}_${
65-
tables[e.startTableId].fields[e.startFieldId].name
66-
}_fk`,
64+
name: `fk_${tables[e.endTableId].name}_${
65+
tables[e.endTableId].fields[e.endFieldId].name
66+
}_${tables[e.startTableId].name}`,
6767
startTableId: e.endTableId,
6868
startFieldId: e.endFieldId,
6969
endTableId: e.startTableId,

Diff for: src/utils/importSQL/mariadb.js

+6-3
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,8 @@ export function fromMariaDB(ast, diagramDb = DB.GENERIC) {
126126
);
127127
if (startFieldId === -1) return;
128128

129-
relationship.name = startTable + "_" + startField + "_fk";
129+
relationship.name =
130+
"fk_" + startTable + "_" + startField + "_" + endTable;
130131
relationship.startTableId = startTableId;
131132
relationship.endTableId = endTableId;
132133
relationship.endFieldId = endFieldId;
@@ -187,7 +188,8 @@ export function fromMariaDB(ast, diagramDb = DB.GENERIC) {
187188
e.expr.forEach((expr) => {
188189
if (
189190
expr.action === "add" &&
190-
expr.create_definitions.constraint_type.toLowerCase() === "foreign key"
191+
expr.create_definitions.constraint_type.toLowerCase() ===
192+
"foreign key"
191193
) {
192194
const relationship = {};
193195
const startTable = e.table[0].table;
@@ -230,7 +232,8 @@ export function fromMariaDB(ast, diagramDb = DB.GENERIC) {
230232
);
231233
if (startFieldId === -1) return;
232234

233-
relationship.name = startTable + "_" + startField + "_fk";
235+
relationship.name =
236+
"fk_" + startTable + "_" + startField + "_" + endTable;
234237
relationship.startTableId = startTableId;
235238
relationship.startFieldId = startFieldId;
236239
relationship.endTableId = endTableId;

Diff for: src/utils/importSQL/mssql.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,8 @@ export function fromMSSQL(ast, diagramDb = DB.GENERIC) {
138138
);
139139
if (startFieldId === -1) return;
140140

141-
relationship.name = startTable + "_" + startField + "_fk";
141+
relationship.name =
142+
"fk_" + startTable + "_" + startField + "_" + endTable;
142143
relationship.startTableId = startTableId;
143144
relationship.endTableId = endTableId;
144145
relationship.endFieldId = endFieldId;
@@ -243,7 +244,8 @@ export function fromMSSQL(ast, diagramDb = DB.GENERIC) {
243244
);
244245
if (startFieldId === -1) return;
245246

246-
relationship.name = startTable + "_" + startField + "_fk";
247+
relationship.name =
248+
"fk_" + startTable + "_" + startField + "_" + endTable;
247249
relationship.startTableId = startTableId;
248250
relationship.startFieldId = startFieldId;
249251
relationship.endTableId = endTableId;

Diff for: src/utils/importSQL/mysql.js

+6-3
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,8 @@ export function fromMySQL(ast, diagramDb = DB.GENERIC) {
126126
);
127127
if (startFieldId === -1) return;
128128

129-
relationship.name = startTable + "_" + startField + "_fk";
129+
relationship.name =
130+
"fk_" + startTable + "_" + startField + "_" + endTable;
130131
relationship.startTableId = startTableId;
131132
relationship.endTableId = endTableId;
132133
relationship.endFieldId = endFieldId;
@@ -187,7 +188,8 @@ export function fromMySQL(ast, diagramDb = DB.GENERIC) {
187188
e.expr.forEach((expr) => {
188189
if (
189190
expr.action === "add" &&
190-
expr.create_definitions.constraint_type.toLowerCase() === "foreign key"
191+
expr.create_definitions.constraint_type.toLowerCase() ===
192+
"foreign key"
191193
) {
192194
const relationship = {};
193195
const startTable = e.table[0].table;
@@ -230,7 +232,8 @@ export function fromMySQL(ast, diagramDb = DB.GENERIC) {
230232
);
231233
if (startFieldId === -1) return;
232234

233-
relationship.name = startTable + "_" + startField + "_fk";
235+
relationship.name =
236+
"fk_" + startTable + "_" + startField + "_" + endTable;
234237
relationship.startTableId = startTableId;
235238
relationship.startFieldId = startFieldId;
236239
relationship.endTableId = endTableId;

Diff for: src/utils/importSQL/postgres.js

+6-3
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,8 @@ export function fromPostgres(ast, diagramDb = DB.GENERIC) {
129129
);
130130
if (startFieldId === -1) return;
131131

132-
relationship.name = startTable + "_" + startField + "_fk";
132+
relationship.name =
133+
"fk_" + startTable + "_" + startField + "_" + endTable;
133134
relationship.startTableId = startTableId;
134135
relationship.endTableId = endTableId;
135136
relationship.endFieldId = endFieldId;
@@ -199,7 +200,8 @@ export function fromPostgres(ast, diagramDb = DB.GENERIC) {
199200
);
200201
if (startFieldId === -1) return;
201202

202-
relationship.name = startTable + "_" + startField + "_fk";
203+
relationship.name =
204+
"fk_" + startTable + "_" + startField + "_" + endTable;
203205
relationship.startTableId = startTableId;
204206
relationship.startFieldId = startFieldId;
205207
relationship.endTableId = endTableId;
@@ -326,7 +328,8 @@ export function fromPostgres(ast, diagramDb = DB.GENERIC) {
326328
);
327329
if (startFieldId === -1) return;
328330

329-
relationship.name = startTable + "_" + startField + "_fk";
331+
relationship.name =
332+
"fk_" + startTable + "_" + startField + "_" + endTable;
330333
relationship.startTableId = startTableId;
331334
relationship.startFieldId = startFieldId;
332335
relationship.endTableId = endTableId;

Diff for: src/utils/importSQL/sqlite.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@ export function fromSQLite(ast, diagramDb = DB.GENERIC) {
6262
);
6363
if (startFieldId === -1) return;
6464

65-
relationship.name = startTable.name + "_" + startFieldName + "_fk";
65+
relationship.name =
66+
"fk_" + startTable.name + "_" + startFieldName + "_" + endTableName;
6667
relationship.startTableId = startTable.id;
6768
relationship.endTableId = endTableId;
6869
relationship.endFieldId = endFieldId;

0 commit comments

Comments
 (0)