Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get_recipients crashes if project member is a group #31

Open
Webovani opened this issue Oct 30, 2012 · 1 comment
Open

Get_recipients crashes if project member is a group #31

Webovani opened this issue Oct 30, 2012 · 1 comment

Comments

@Webovani
Copy link

If member.user_id points to Group, member.user is nil and DigestMailer.get_recipients crashes.

Called id for nil, which would mistakenly be 4 -- if you really wanted the id of nil, use object_id
/Users/bubak/rails/redmine-1.3.3/vendor/plugins/redmine_digest/app/models/digest_mailer.rb:166:in `get_recipients'
/Users/bubak/rails/redmine-1.3.3/vendor/plugins/redmine_digest/app/models/digest_mailer.rb:164:in `each'
/Users/bubak/rails/redmine-1.3.3/vendor/plugins/redmine_digest/app/models/digest_mailer.rb:164:in `get_recipients'
/Users/bubak/rails/redmine-1.3.3/vendor/plugins/redmine_digest/app/models/digest_mailer.rb:213:in `digests'
/Users/bubak/rails/redmine-1.3.3/vendor/plugins/redmine_digest/app/models/digest_mailer.rb:194:in `each'
/Users/bubak/rails/redmine-1.3.3/vendor/plugins/redmine_digest/app/models/digest_mailer.rb:194:in `digests'
@janthurau
Copy link
Contributor

Should be fixed by PR #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janthurau @Webovani