Facades are rewritten to Service via StaticCallOnNonStaticToInstanceCallRector

[Jaspur]

Hi,

How can I prevent that Facades are being rewritten to Service classes?

-        $subtotal = Webshop::calculateTotals($order->cart, $order->country, coupon: $coupon);
+        $subtotal = (new Webshop())->calculateTotals($order->cart, $order->country, coupon: $coupon);

Want to keep the Facade-way, because Facade isn't static.

Adding one of those to withSkip() didn't help: ThisCallOnStaticMethodToStaticCallRector::class & StaticCallOnNonStaticToInstanceCallRector

[GeniJaho]

@Jaspur skipping StaticCallOnNonStaticToInstanceCallRector should work, unless there is some other rule that is making the change. When you run Rector (also with --dry-run), you can see which rule made the change, and you can skip it.
If that doesn't work, can you share the rules you're using and skipping in your RectorConfig, please?

[peterfox]

@Jaspur I have a feeling this is maybe caused by the namespace of your classes. Can you provide a sample where the namespaces are provided as well for context?

This is technically a problem rule to rules in the main rector repo as well, which would be out of scope for this project.