Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera support? #664

Open
antonvh opened this issue Sep 12, 2016 · 3 comments
Open

Camera support? #664

antonvh opened this issue Sep 12, 2016 · 3 comments

Comments

@antonvh
Copy link

antonvh commented Sep 12, 2016

I'm coding camera control and geotagging. Would you like to add camera classes to dronekit? Would you like a PR?

Here's my first working code: https://github.com/antonvh/dronekit-python/blob/gopro_wifi/dronekit/cameras.py

Would I add a camera object to the vehicle class? Or a vehicle object to the camera class so the shutter can log gps data?

@hamishwillee
Copy link
Contributor

Thanks @antonvh

@mrpollo @peterbarker These are architectural questions, best answered by you guys. Ideally we'd provide a pluggable-camera API.

Even if we can't include now, we should add to the Notable projects using DK

@mrpollo
Copy link
Member

mrpollo commented Sep 14, 2016

@antonvh why don't you submit the PR?, I think it would be a great addition to dronekit, once you submit a PR I'll give you some feedback

@antonvh
Copy link
Author

antonvh commented Sep 14, 2016

PR done: #665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants