V2 Tx: apply SSB BPF to data and EOO uniformly, default on

radae_v2.py's RADEv2Transmitter (used by tx2.py, the streaming reference
rade_c ports) previously used a different, narrower carrier-bandwidth-derived
filter than inference.py's actual SSB radio emulation (300-2700Hz, matching
training), and never filtered the EOO frame at all. Both now use the same
300-2700Hz filter, applied continuously across data and EOO through one
persistent filter state -- a real SSB radio's front end doesn't distinguish
data samples from EOO ones.

tx2.py's --ssb_bpf flipped to default-on (--no_bpf added as opt-out,
matching the existing --no_auxdata/--no_eoo pattern), since this is the
filter the model was actually trained under. inference.py's own default is
left untouched; --ssb_bpf added explicitly to the v2_tx2 ctest to keep it
matched now that tx2.sh defaults to filtered.

Also replaces rade_c_v2_rx_eoo (which used inference.py's --end_of_over_v2
splice -- AWGN-only on the EOO tail regardless of channel flags, and never
SSB-filtered) with a tx2.py -> ch -> C rx stack that genuinely fades/filters
the whole continuous data+EOO stream, plus MPP variants for both tx2.py and
the C Tx.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PzNQqmYXwUStAMrN4a5GFy

Author: drowe67

CMakeLists.txt

@@ -737,7 +737,11 @@ add_test(NAME rade_c_v2_dec
          set_tests_properties(rade_c_v2_dec PROPERTIES PASS_REGULAR_EXPRESSION "PASS")
 
 # Test V2 C transmitter: compare IQ output to tx2.py reference using RMS difference
-# EOO max diff threshold: 1e-4 (essentially float32 precision)
+# EOO max diff threshold: 0.01 -- the SSB BPF is one continuous filter spanning the
+# data->EOO boundary, so its memory carries the pre-existing ~1.2% data-side encoder
+# float difference into the start of the EOO window as a decaying transient (observed
+# peak ~0.006, decaying to ~1e-5 by the end of the 960-sample EOO window); a tight
+# near-float32-precision threshold is no longer the right expectation here.
 # Data diff_rms/sig_rms threshold: 3% (encoder float differences are ~1.2%)
 add_test(NAME rade_c_v2_tx
          COMMAND sh -c "cd ${CMAKE_SOURCE_DIR}; \
@@ -756,7 +760,7 @@ diff_rms=np.sqrt(np.mean(np.abs(data_py-data_c)**2)); \
 sig_rms=np.sqrt(np.mean(np.abs(data_py)**2)); \
 eoo_max=np.max(np.abs(eoo_py-eoo_c)); \
 print(f'diff_rms/sig_rms: {diff_rms/sig_rms:.4f}  eoo_max_diff: {eoo_max:.2e}'); \
-ok = diff_rms/sig_rms < 0.03 and eoo_max < 1e-4; \
+ok = diff_rms/sig_rms < 0.03 and eoo_max < 0.01; \
 print('PASS' if ok else 'FAIL')\"")
          set_tests_properties(rade_c_v2_tx PROPERTIES PASS_REGULAR_EXPRESSION "PASS")
 
@@ -820,17 +824,38 @@ add_test(NAME rade_c_v2_rx_mpp_low
              python3 loss.py features_in.f32 features_rx_v2_c.f32 --loss_test 0.40 --clip_start 100 --clip_end 300")
          set_tests_properties(rade_c_v2_rx_mpp_low PROPERTIES PASS_REGULAR_EXPRESSION "PASS")
 
-# V2 C receiver EOO detection: MPP channel at EbNodB=8 (mirrors v2_eoo_mpp_low)
+# V2 C receiver EOO detection: tx2.py -> ch -> C rx, AWGN channel.
 add_test(NAME rade_c_v2_rx_eoo
          COMMAND sh -c "cd ${CMAKE_SOURCE_DIR}; \
-             test/make_g.sh; \
-             ./inference.sh 250725/checkpoints/checkpoint_epoch_200.pth wav/brian_g8sez.wav /dev/null \
-             --rate_Fs --latent-dim 56 --peak --cp 0.004 --time_offset -16 --correct_time_offset -16 \
-             --auxdata --w1_dec 128 --end_of_over_v2 --write_rx rx_v2_eoo_test.f32 \
-             --append_noise 1 --g_file g_mpp.f32 --EbNodB 8; \
-             cat rx_v2_eoo_test.f32 | ${RADE_C_BUILD_DIR}/src/radae_rx --v2 -v 0 2>&1 >/dev/null")
+             ./tx2.sh 250725/checkpoints/checkpoint_epoch_200.pth wav/brian_g8sez.wav v2_eoo_tx2.f32; \
+             cat v2_eoo_tx2.f32 | python3 f32toint16.py --real --scale 16383 | \
+             ${CMAKE_BINARY_DIR}/src/ch - - --No -24 | python3 int16tof32.py --zeropad > v2_eoo_rx2.f32; \
+             cat v2_eoo_rx2.f32 | ${RADE_C_BUILD_DIR}/src/radae_rx --v2 -v 0 2>&1 >/dev/null")
          set_tests_properties(rade_c_v2_rx_eoo PROPERTIES PASS_REGULAR_EXPRESSION "End-of-over detected")
 
+# V2 C receiver EOO detection: tx2.py -> ch -> C rx, MPP fading channel.
+# scale 8192 (rather than 16383) + No -30 gives the same ~10dB SNR3k as the AWGN
+# test above with zero clipping from multipath anti-fade peaks (16383 clips ~0.09%).
+add_test(NAME rade_c_v2_rx_eoo_mpp
+         COMMAND sh -c "cd ${CMAKE_SOURCE_DIR}; \
+             test/make_g.sh; \
+             ./tx2.sh 250725/checkpoints/checkpoint_epoch_200.pth wav/brian_g8sez.wav v2_eoo_mpp_tx2.f32; \
+             cat v2_eoo_mpp_tx2.f32 | python3 f32toint16.py --real --scale 8192 | \
+             ${CMAKE_BINARY_DIR}/src/ch - - --No -30 --mpp --fading_dir . | python3 int16tof32.py --zeropad > v2_eoo_mpp_rx2.f32; \
+             cat v2_eoo_mpp_rx2.f32 | ${RADE_C_BUILD_DIR}/src/radae_rx --v2 -v 0 2>&1 >/dev/null")
+         set_tests_properties(rade_c_v2_rx_eoo_mpp PROPERTIES PASS_REGULAR_EXPRESSION "End-of-over detected")
+
+# V2 C receiver EOO detection: C tx (radae_tx) -> ch -> C rx, MPP fading channel.
+add_test(NAME rade_c_v2_tx_eoo_mpp
+         COMMAND sh -c "cd ${CMAKE_SOURCE_DIR}; \
+             test/make_g.sh; \
+             ${CMAKE_CURRENT_BINARY_DIR}/src/lpcnet_demo -features wav/brian_g8sez.wav features_in.f32; \
+             cat features_in.f32 | ${RADE_C_BUILD_DIR}/src/radae_tx --v2 > v2_eoo_ctx.f32; \
+             cat v2_eoo_ctx.f32 | python3 f32toint16.py --real --scale 8192 | \
+             ${CMAKE_BINARY_DIR}/src/ch - - --No -30 --mpp --fading_dir . | python3 int16tof32.py --zeropad > v2_eoo_ctx_rx.f32; \
+             cat v2_eoo_ctx_rx.f32 | ${RADE_C_BUILD_DIR}/src/radae_rx --v2 -v 0 2>&1 >/dev/null")
+         set_tests_properties(rade_c_v2_tx_eoo_mpp PROPERTIES PASS_REGULAR_EXPRESSION "End-of-over detected")
+
 # V2 C receiver SNR estimator: high SNR (EbNodB=12, mirrors v2_snr_est_high)
 add_test(NAME rade_c_v2_rx_snr_high
          COMMAND sh -c "cd ${CMAKE_SOURCE_DIR}; \
@@ -1274,7 +1299,7 @@ add_test(NAME v2_tx2
                        ./tx2.sh 250725/checkpoints/checkpoint_epoch_200.pth wav/brian_g8sez.wav v2_tx2_rx.f32; \
                        python3 inference.py 250725/checkpoints/checkpoint_epoch_200.pth features_in.f32 features_out.f32 \
                        --latent-dim 56 --w1_dec 128 --auxdata --rate_Fs --cp 0.004 \
-                       --time_offset -16 --correct_time_offset -8 --peak; \
+                       --time_offset -16 --correct_time_offset -8 --peak --ssb_bpf; \
                        ./rx2.sh 250725/checkpoints/checkpoint_epoch_200.pth 250725a_ml_sync v2_tx2_rx.f32 /dev/null --quiet; \
                        python3 loss.py features_in.f32 features_out.f32 --features_hat2 features_out_rx2.f32 \
                        --clip_start 100 --clip_end 300 --compare --delta 0.05")
@@ -1291,7 +1316,7 @@ add_test(NAME v2_tx2_ch
                        ./rx2.sh 250725/checkpoints/checkpoint_epoch_200.pth 250725a_ml_sync v2_tx2ch_inf_rx.f32 /dev/null \
                        --agc --gain 1.22E-4 --quiet; \
                        cp features_out_rx2.f32 features_out_rx2_inf.f32; \
-                       ./tx2.sh 250725/checkpoints/checkpoint_epoch_200.pth wav/brian_g8sez.wav v2_tx2ch_tx.f32 --ssb_bpf; \
+                       ./tx2.sh 250725/checkpoints/checkpoint_epoch_200.pth wav/brian_g8sez.wav v2_tx2ch_tx.f32; \
                        cat v2_tx2ch_tx.f32 | python3 f32toint16.py --real --scale 16383 | ${CMAKE_BINARY_DIR}/src/ch - - --No -20 | python3 int16tof32.py --zeropad > v2_tx2ch_rx.f32; \
                        ./rx2.sh 250725/checkpoints/checkpoint_epoch_200.pth 250725a_ml_sync v2_tx2ch_rx.f32 /dev/null \
                        --agc --gain 1.22E-4 --quiet; \

radae_v2.py

@@ -367,14 +367,17 @@ def __init__(self, model):
 
       self.ssb_bpf_en = model.ssb_bpf
       if self.ssb_bpf_en:
-         # Streaming complex BPF with same parameters as model
+         # Streaming complex BPF, same 300-2700Hz SSB radio front end the model
+         # was trained under (radae.py's ssb_bpf) -- applied to both regular
+         # frames and the EOO sequence via the same continuous filter state,
+         # since a real SSB radio's passband doesn't distinguish data from EOO.
          from radae import complex_bpf as ComplexBPF
          Ntap      = 101
-         w         = model.w.cpu().numpy()
          Fs        = float(model.Fs)
-         bandwidth = 1.2 * (w[model.Nc - 1] - w[0]) * Fs / (2 * np.pi)
-         centre    = (w[model.Nc - 1] + w[0]) * Fs / (2 * np.pi) / 2
-         frame_len = self.Ns * self.sym_len
+         bandwidth = 2700 - 300
+         centre    = (2700 + 300) / 2
+         eoo_len   = model.eoo_v2.numel()
+         frame_len = max(self.Ns * self.sym_len, eoo_len)
          self._ssb_bpf = ComplexBPF(Ntap, Fs, bandwidth, centre, frame_len)
 
    def transmit_frame(self, features):
@@ -412,4 +415,7 @@ def transmit_frame(self, features):
 
    def eoo(self):
       """Return the V2 end-of-over sequence as complex64 IQ samples."""
-      return self.model.eoo_v2.numpy().flatten().astype(np.csingle)
+      eoo = self.model.eoo_v2.numpy().flatten().astype(np.csingle)
+      if self.ssb_bpf_en:
+         eoo = self._ssb_bpf.bpf(eoo)
+      return eoo

tx2.py

@@ -54,8 +54,9 @@
 parser.add_argument('--w2_enc', type=int, default=96, help='encoder conv output dimension (default 96)')
 parser.add_argument('--w1_dec', type=int, default=128, help='decoder GRU output dimension, needed for checkpoint loading (default 128)')
 parser.add_argument('--w2_dec', type=int, default=32, help='decoder conv output dimension, needed for checkpoint loading (default 32)')
-parser.add_argument('--ssb_bpf', action='store_true', help='apply SSB BPF (default off)')
 parser.add_argument('--write_latent', type=str, default="", help='path to output latent vectors z[latent_dim] in .f32 format')
+parser.set_defaults(ssb_bpf=True)
+parser.add_argument('--no_bpf', action='store_false', dest='ssb_bpf', help='disable SSB BPF (default enabled)')
 parser.set_defaults(auxdata=True)
 parser.add_argument('--no_auxdata', action='store_false', dest='auxdata', help='disable auxiliary data symbol (default enabled)')
 parser.set_defaults(end_of_over_v2=True)