Ability to attach dependencies of a library

[philwolstenholme]

Right now, given the code below, I believe it will only be text-in-circle.js that is attached:

text-in-circle:
  js:
    dist/03-organisms/text-in-circle/text-in-circle.js: {}
  dependencies:
  - core/jquery
  - rutherford/shave

It would be great (and match Drupal's behaviour) if the listed dependencies could be included too (and linked to on the page prior to text-in-circle.js.

[philwolstenholme]

I wonder if we could piggyback on the Drupal code for resolving dependencies, similarly to how aleksip/plugin-data-transform has copied the Drupal classes for Attribute, Link etc into that plugin to make the Drupal logic available in Pattern Lab https://github.com/aleksip/plugin-data-transform/blob/develop/src/Drupal/Core/Template/Attribute.php

[waako]

So you are thinking using the core/lib/Drupal/Core/Asset/LibraryDiscoverParser.php and LibraryDependencyResolver.php along with other related files?

Guess would need to set relative paths to core/module libraries for dependencies?

[philwolstenholme]

Hi @waako, this isn't really an area I know a lot about, but those files look like the sort of things I had in mind.