feat(phpcs): Correct any issues reported by phpcs

Author: sylus

src/Controller/LibraryController.php

@@ -6,9 +6,14 @@
 use Drupal\Core\Controller\ControllerBase;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
+/**
+ * Provides a library controller.
+ */
 class LibraryController extends ControllerBase {
 
   /**
+   * The library service.
+   *
    * @var \Drupal\wxt_library\LibraryService
    */
   protected $wxtLibraryService;

src/Form/SearchApiBlockForm.php

@@ -127,7 +127,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
   }
 
   /**
-   * Custom after build to remove elements from being submitted as GET variables.
+   * Remove elements from being submitted as GET variables.
    */
   public function afterBuild(array $element, FormStateInterface $form_state) {
     // Remove the form_build_id, form_id and op from the GET parameters.

src/Form/SearchBlockForm.php

@@ -111,7 +111,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
     $form['keys'] = [
       '#id' => 'wb-srch-q',
       '#type' => 'search',
-      '#title' => t('Search'),
+      '#title' => $this->t('Search'),
       '#title_display' => 'invisible',
       '#size' => 27,
       '#maxlength' => 128,

src/Form/SearchCanadaBlockForm.php

@@ -6,6 +6,7 @@
 use Drupal\Core\Form\FormBase;
 use Drupal\Core\Form\FormStateInterface;
 use Drupal\Core\Render\RendererInterface;
+use Drupal\Core\Language\LanguageManagerInterface;
 use Drupal\wxt_library\LibraryService;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
@@ -21,6 +22,13 @@ class SearchCanadaBlockForm extends FormBase {
    */
   protected $configFactory;
 
+  /**
+   * Language manager for retrieving the default langcode.
+   *
+   * @var \Drupal\Core\Language\LanguageManagerInterface
+   */
+  protected $languageManager;
+
   /**
    * The renderer.
    *
@@ -40,17 +48,21 @@ class SearchCanadaBlockForm extends FormBase {
    *
    * @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory
    *   The config factory.
+   * @param \Drupal\Core\Language\LanguageManagerInterface $language_manager
+   *   The language manager.
    * @param \Drupal\Core\Render\RendererInterface $renderer
    *   The renderer.
    * @param \Drupal\wxt_library\LibraryService $wxt_library_service_wxt
    *   The LibraryService.
    */
   public function __construct(
     ConfigFactoryInterface $config_factory,
+    LanguageManagerInterface $language_manager,
     RendererInterface $renderer,
     LibraryService $wxt_library_service_wxt
   ) {
     $this->configFactory = $config_factory;
+    $this->languageManager = $language_manager;
     $this->renderer = $renderer;
     $this->wxtLibraryServiceWxT = $wxt_library_service_wxt;
   }
@@ -83,7 +95,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
     $form['keys'] = [
       '#id' => 'wb-srch-q',
       '#type' => 'search',
-      '#title' => t('Search'),
+      '#title' => $this->t('Search'),
       '#title_display' => 'invisible',
       '#size' => 27,
       '#maxlength' => 128,
@@ -112,7 +124,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
     $form['submit_container']['submit']['#value'] = '';
     $form['keys']['#placeholder'] = $this->t('Search website');
 
-    $lang = \Drupal::languageManager()->getCurrentLanguage()->getId();
+    $lang = $this->languageManager->getCurrentLanguage()->getId();
 
     $form['#action'] = 'https://www.canada.ca/' . $lang . '/sr/srb.html#wb_land';
     $form['#method'] = 'get';

src/LibraryService.php

@@ -5,14 +5,21 @@
 use Drupal\Core\Config\ConfigFactoryInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
+/**
+ * Provides a library service for WxT.
+ */
 class LibraryService {
 
   /**
+   * Consructs the library name.
+   *
    * @var string
    */
   protected $libraryName;
 
   /**
+   * Consructs the library path.
+   *
    * @var string
    */
   protected $libraryPath;

src/Plugin/Block/DateModifiedBlock.php

@@ -5,7 +5,6 @@
 use Drupal\Component\Datetime\TimeInterface;
 use Drupal\Core\Block\BlockBase;
 use Drupal\Core\Datetime\DateFormatter;
-use Drupal\Core\Datetime\Entity\DateFormat;
 use Drupal\Core\Entity\EntityStorageInterface;
 use Drupal\Core\Form\FormStateInterface;
 use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
@@ -30,6 +29,13 @@ class DateModifiedBlock extends BlockBase implements ContainerFactoryPluginInter
    */
   protected $requestStack;
 
+  /**
+   * The date format storage.
+   *
+   * @var \Drupal\Core\Entity\EntityStorageInterface
+   */
+  protected $dateFormatStorage;
+
   /**
    * The node storage.
    *
@@ -60,6 +66,8 @@ class DateModifiedBlock extends BlockBase implements ContainerFactoryPluginInter
    *   The plugin_id for the plugin instance.
    * @param string $plugin_definition
    *   The plugin implementation definition.
+   * @param \Drupal\Core\Entity\EntityStorageInterface $date_format_storage
+   *   Entity storage for date_format entities.
    * @param \Drupal\Core\Datetime\DateFormatter $date_formatter
    *   The date formatter service.
    * @param \Symfony\Component\HttpFoundation\RequestStack $request_stack
@@ -73,12 +81,14 @@ public function __construct(
         array $configuration,
         $plugin_id,
         $plugin_definition,
+        EntityStorageInterface $date_format_storage,
         DateFormatter $date_formatter,
         RequestStack $request_stack,
         EntityStorageInterface $node_storage,
         TimeInterface $date_time
   ) {
     parent::__construct($configuration, $plugin_id, $plugin_definition);
+    $this->dateFormatStorage = $date_format_storage;
     $this->dateFormatter = $date_formatter;
     $this->requestStack = $request_stack;
     $this->nodeStorage = $node_storage;
@@ -93,6 +103,7 @@ public static function create(ContainerInterface $container, array $configuratio
       $configuration,
       $plugin_id,
       $plugin_definition,
+      $container->get('entity_type.manager')->getStorage('date_format'),
       $container->get('date.formatter'),
       $container->get('request_stack'),
       $container->get('entity_type.manager')->getStorage('node'),
@@ -162,7 +173,7 @@ public function build() {
       $formatted_date = 'Y-m-d';
     }
     else {
-      $formatted_date = DateFormat::load($format)->getPattern();
+      $formatted_date = $this->dateFormatStorage->load($format)->getPattern();
     }
     $date = $this->dateFormatter->format($time, 'custom', $formatted_date);
 

src/Plugin/Block/LanguageBlock.php

@@ -124,8 +124,6 @@ public function build() {
     $current = $this->urlGenerator->generateFromRoute('<current>', [], [], TRUE)->getGeneratedUrl();
     $front = $this->aliasManager->getPathByAlias($current);
     $frontAlias = $this->configFactory->get('system.site')->get('page.front');
-
-    $config = $this->configuration;
     $build = [];
     $route_name = $this->pathMatcher->isFrontPage() ? '<front>' : '<current>';
 

src/Plugin/Block/UserAccountBlock.php

@@ -73,13 +73,19 @@ public function build() {
     $build['user_account_block']['#markup'] .= '<div class="col-md-12 text-right">';
 
     if (!in_array("authenticated", $roles)) {
-      $build['user_account_block']['#markup'] .= Link::fromTextAndUrl($this->t('Register'), Url::fromRoute('user.register', [], ['attributes' => ['class' => 'btn btn-default']]))->toString() . "\n";
+      $build['user_account_block']['#markup'] .= Link::fromTextAndUrl($this->t('Register'), Url::fromRoute('user.register', [], [
+        'attributes' => ['class' => 'btn btn-default'],
+      ]))->toString() . "\n";
       $build['user_account_block']['#markup'] .= Link::fromTextAndUrl($this->t('Sign in'), Url::fromRoute('user.login', [], ['attributes' => ['class' => 'btn btn-primary']]))->toString() . "\n";
     }
     else {
       $build['user_account_block']['#markup'] .= '<p class="mrgn-rght-sm display-inline">' . $this->t('Signed in as') . '<span class="wb-so-uname">' . ' ' . $account_name . '</span></p>';
-      $build['user_account_block']['#markup'] .= Link::fromTextAndUrl($this->t('Account settings'), Url::fromRoute('user.page', [], ['attributes' => ['class' => 'btn btn-default', 'role' => 'button']]))->toString() . "\n";
-      $build['user_account_block']['#markup'] .= Link::fromTextAndUrl($this->t('Sign out'), Url::fromRoute('user.logout', [], ['attributes' => ['class' => 'btn btn-primary', 'role' => 'button']]))->toString() . "\n";
+      $build['user_account_block']['#markup'] .= Link::fromTextAndUrl($this->t('Account settings'), Url::fromRoute('user.page', [], [
+        'attributes' => ['class' => 'btn btn-default', 'role' => 'button'],
+      ]))->toString() . "\n";
+      $build['user_account_block']['#markup'] .= Link::fromTextAndUrl($this->t('Sign out'), Url::fromRoute('user.logout', [], [
+        'attributes' => ['class' => 'btn btn-primary', 'role' => 'button'],
+      ]))->toString() . "\n";
     }
 
     $build['user_account_block']['#markup'] .= '</div></section>';

src/Plugin/Condition/PanelsTitle.php

@@ -222,7 +222,7 @@ public function evaluate() {
    */
   public function summary() {
     if (!empty($this->configuration['is_panelized'])) {
-      return t('Is a panelized page with a title');
+      return $this->t('Is a panelized page with a title');
     }
   }
 

src/TwigExtension/LibraryTwig.php

@@ -2,6 +2,9 @@
 
 namespace Drupal\wxt_library\TwigExtension;
 
+/**
+ * Provides a twig extension for WxT.
+ */
 class LibraryTwig extends \Twig_Extension {
 
   /**

tests/src/Kernel/LibraryTest.php

@@ -38,13 +38,19 @@ class LibraryTest extends KernelTestBase {
    */
   protected $pluginManager;
 
+  /**
+   * Setup the test.
+   */
   protected function setUp(): void {
     parent::setUp();
 
     $this->installConfig('wxt_library');
     $this->pluginManager = $this->container->get('wxt_library.service_wxt');
   }
 
+  /**
+   * Test the library.
+   */
   public function testLibrary() {
     $this->assertSame('wet_boew', $this->pluginManager->getLibraryName());
     $this->assertSame('/libraries/theme-wet-boew', $this->pluginManager->getLibraryPath());

wxt_library.module

@@ -121,7 +121,8 @@ function _wxt_library_check_theme() {
 function _wxt_library_check_url() {
   // Make it possible deactivate bootstrap with
   // parameter ?wxt_library=no in the url.
-  if (isset($_GET['wxt_library']) && $_GET['wxt_library'] == 'no') {
+  $query_string = \Drupal::service('request_stack')->getCurrentRequest()->query->get('wxt_library');
+  if (isset($query_string) && $query_string == 'no') {
     return FALSE;
   }
 
@@ -181,12 +182,12 @@ function _wxt_library_options() {
 /**
  * Gets the path of a library.
  *
- * @param $name
+ * @param string $name
  *   The machine name of a library to return the path for.
- * @param $base_path
+ * @param string $base_path
  *   Whether to prefix the resulting path with base_path().
  *
- * @return
+ * @return string
  *   The path to the specified library or FALSE if the library wasn't found.
  */
 function _wxt_library_get_path($name, $base_path = FALSE) {
@@ -218,7 +219,7 @@ function _wxt_library_get_path($name, $base_path = FALSE) {
  * in both the site-wide directory and site-specific directory, only the
  * site-specific version will be listed.
  *
- * @return
+ * @return array
  *   A list of library directories.
  */
 function _wxt_library_get_libraries() {