Define test repo as module.

[bigzed]

The change allows pronto-simplecov to be included in a Gemfile with

gem 'pronto_simplecov', github: 'dsander/pronto-simplecov'', branch: 'master'

before bundle failed with:

fatal: No url found for submodule path 'spec/data/test' in .gitmodules

[dsander]

Hmm this is odd, I tried adding the current master branch to both a normal Gemfile and one that is a submodule of a different git repository and didn't have the issue. Is it specific to our setup at work?

[bigzed]

This is the error I get, when I add pronto-simplecov with gem 'pronto-simplecov', github: 'dsander/pronto-simplecov', branch: 'master' to view-farm. Even if I removed the directory the error suggests, the next bundle still fails.

Fetching https://github.com/dsander/pronto-simplecov.git
fatal: No url found for submodule path 'spec/data/test' in .gitmodules

Retrying `git submodule foreach --quiet git\ -C\ \$toplevel\ submodule\ deinit\ --force\ \$sm_path` at /home/steved/.rbenv/versions/2.5.8/lib/ruby/gems/2.5.0/bundler/gems/pronto-simplecov-092b000edc8e due to error (2/4): Bundler::Source::Git::GitCommandError Git error: command `git submodule foreach --quiet git\ -C\ \$toplevel\ submodule\ deinit\ --force\ \$sm_path` in directory /home/steved/.rbenv/versions/2.5.8/lib/ruby/gems/2.5.0/bundler/gems/pronto-simplecov-092b000edc8e has failed.

If this error persists you could try removing the cache directory '/home/steved/.rbenv/versions/2.5.8/lib/ruby/gems/2.5.0/bundler/gems/pronto-simplecov-092b000edc8e'

Retrying `git submodule foreach --quiet git\ -C\ \$toplevel\ submodule\ deinit\ --force\ \$sm_path` at /home/steved/.rbenv/versions/2.5.8/lib/ruby/gems/2.5.0/bundler/gems/pronto-simplecov-092b000edc8e due to error (3/4): Bundler::Source::Git::GitCommandError Git error: command `git submodule foreach --quiet git\ -C\ \$toplevel\ submodule\ deinit\ --force\ \$sm_path` in directory /home/steved/.rbenv/versions/2.5.8/lib/ruby/gems/2.5.0/bundler/gems/pronto-simplecov-092b000edc8e has failed.

If this error persists you could try removing the cache directory '/home/steved/.rbenv/versions/2.5.8/lib/ruby/gems/2.5.0/bundler/gems/pronto-simplecov-092b000edc8e'

Retrying `git submodule foreach --quiet git\ -C\ \$toplevel\ submodule\ deinit\ --force\ \$sm_path` at /home/steved/.rbenv/versions/2.5.8/lib/ruby/gems/2.5.0/bundler/gems/pronto-simplecov-092b000edc8e due to error (4/4): Bundler::Source::Git::GitCommandError Git error: command `git submodule foreach --quiet git\ -C\ \$toplevel\ submodule\ deinit\ --force\ \$sm_path` in directory /home/steved/.rbenv/versions/2.5.8/lib/ruby/gems/2.5.0/bundler/gems/pronto-simplecov-092b000edc8e has failed.

If this error persists you could try removing the cache directory '/home/steved/.rbenv/versions/2.5.8/lib/ruby/gems/2.5.0/bundler/gems/pronto-simplecov-092b000edc8e'

Git error: command `git submodule foreach --quiet git\ -C\ \$toplevel\ submodule\ deinit\ --force\ \$sm_path` in directory /home/steved/.rbenv/versions/2.5.8/lib/ruby/gems/2.5.0/bundler/gems/pronto-simplecov-092b000edc8e has failed.

If this error persists you could try removing the cache directory '/home/steved/.rbenv/versions/2.5.8/lib/ruby/gems/2.5.0/bundler/gems/pronto-simplecov-092b000edc8e'

[dsander]

I could not reproduce this neither when bundle installing natively (ruby is installed with asdf) nor with our dockerized development environment. The change kind of makes sense to me, but I'd like to understand why it's required in some cased, but isn't in others.