Fix rubocop errors

Author: dsandstrom

.rubocop.yml

@@ -49,7 +49,7 @@ Metrics/BlockLength:
 Metrics/ClassLength:
   Exclude:
     - 'db/seeds.rb'
-  Max: 150
+  Max: 180
 
 Metrics/ModuleLength:
   Max: 150
@@ -60,6 +60,9 @@ Naming/FileName:
     - 'Guardfile'
     - 'Rakefile'
 
+Rails/I18nLocaleTexts:
+  Enabled: false
+
 Style/Documentation:
   Enabled: false
 

app/classes/html_renderer.rb

@@ -5,7 +5,7 @@ class HTMLRenderer < Redcarpet::Render::HTML
               no_styles: true, prettify: true, safe_links_only: true }.freeze
 
   def initialize(*_)
-    super OPTIONS.dup
+    super(OPTIONS.dup)
   end
 
   def header(text, header_level)

app/controllers/api/v1/webhooks_controller.rb

@@ -38,7 +38,7 @@ def commit_payload?
         end
 
         def app_secret
-          @app_secret ||= ENV['GITHUB_WEBHOOK_SECRET']
+          @app_secret ||= ENV.fetch('GITHUB_WEBHOOK_SECRET', nil)
         end
 
         def request_signature
@@ -90,7 +90,7 @@ def issue_params
               issue_type: issue_type,
               user: github_user,
               summary: issue_payload[:title],
-              description: (issue_payload[:body].presence || 'Imported') }
+              description: issue_payload[:body].presence || 'Imported' }
         end
 
         def github_user_valid?
@@ -153,14 +153,21 @@ def process_commit(payload)
           end
         end
 
+        def callout_message(callout)
+          return unless callout&.errors
+
+          errors = callout.errors
+          errors&.messages&.inspect
+        end
+
         def perform_repo_callout_action(repo_callout)
           repo_callout.process_commit_message
           return unless repo_callout.save!
 
           repo_callout.perform_action
         rescue ActiveRecord::RecordInvalid
           logger.info "GitHub commit can't be process. RepoCallout is invalid:"
-          logger.info repo_callout&.errors&.messages&.inspect
+          logger.info callout_message(repo_callout)
         end
 
         def process_user(payload)

app/controllers/issue_comments_controller.rb

@@ -6,25 +6,25 @@ class IssueCommentsController < ApplicationController
   load_and_authorize_resource :issue
   load_and_authorize_resource through: :issue, through_association: :comments
 
-  def new
+  def show
     respond_to do |format|
-      format.html
+      format.html do
+        redirect_to issue_path(@issue, anchor: "comment-#{@issue_comment.id}")
+      end
       format.js
     end
   end
 
-  def edit
+  def new
     respond_to do |format|
       format.html
       format.js
     end
   end
 
-  def show
+  def edit
     respond_to do |format|
-      format.html do
-        redirect_to issue_path(@issue, anchor: "comment-#{@issue_comment.id}")
-      end
+      format.html
       format.js
     end
   end

app/controllers/issue_subscriptions_controller.rb

@@ -28,8 +28,8 @@ def destroy
   private
 
     def create_success
-      notice = "Subscribed to Issue ##{@issue.id}. You will be notified after "\
-               'updates.'
+      notice = "Subscribed to Issue ##{@issue.id}. You will be notified " \
+               'after updates.'
       respond_to do |format|
         format.html { redirect_back fallback_location: @issue, notice: notice }
         format.js { render :show }

app/controllers/task_comments_controller.rb

@@ -4,25 +4,25 @@ class TaskCommentsController < ApplicationController
   load_and_authorize_resource :task
   load_and_authorize_resource through: :task, through_association: :comments
 
-  def new
+  def show
     respond_to do |format|
-      format.html
+      format.html do
+        redirect_to task_path(@task, anchor: "comment-#{@task_comment.id}")
+      end
       format.js
     end
   end
 
-  def edit
+  def new
     respond_to do |format|
       format.html
       format.js
     end
   end
 
-  def show
+  def edit
     respond_to do |format|
-      format.html do
-        redirect_to task_path(@task, anchor: "comment-#{@task_comment.id}")
-      end
+      format.html
       format.js
     end
   end

app/controllers/task_subscriptions_controller.rb

@@ -28,7 +28,7 @@ def destroy
   private
 
     def create_success
-      notice = "Subscribed to Task ##{@task.id}. You will be notified after "\
+      notice = "Subscribed to Task ##{@task.id}. You will be notified after " \
                'updates.'
       respond_to do |format|
         format.html { redirect_back fallback_location: @task, notice: notice }

app/helpers/issues_helper.rb

@@ -221,8 +221,8 @@ def issue_open_status_reviewer_links(issue)
     def issue_connection_links(connection)
       return unless can?(:destroy, connection)
 
-      confirm = 'Are you sure you want to remove the connection to '\
-                "\"#{connection.target.short_summary}\" and reopen "\
+      confirm = 'Are you sure you want to remove the connection to ' \
+                "\"#{connection.target.short_summary}\" and reopen " \
                 'this issue?'
 
       [['Reopen Issue', connection,

app/helpers/tasks_helper.rb

@@ -200,8 +200,8 @@ def task_open_status_reviewer_links(task)
     def task_connection_links(connection)
       return unless can?(:destroy, connection)
 
-      confirm = 'Are you sure you want to remove the connection to '\
-                "\"#{connection.target.short_summary}\" and reopen "\
+      confirm = 'Are you sure you want to remove the connection to ' \
+                "\"#{connection.target.short_summary}\" and reopen " \
                 'this task?'
 
       [['Reopen Task', connection,

app/helpers/users_helper.rb

@@ -92,7 +92,7 @@ def users_page_title(name)
 
     def new_user_header(user)
       heading =
-        "New #{user.employee_type&.present? ? user.employee_type : 'User'}"
+        "New #{user.employee_type.presence || 'User'}"
       content_for :header do
         concat user_breadcrumbs
         concat content_tag(:h1, heading)