Readme and tests

Author: dsentker

README.md

@@ -33,7 +33,8 @@ foreach($result->getFormattedResults()->getRuleResults() as $rule => $ruleResult
         var_dump($ruleResult->getLocalizedRuleName()); // "Zielseiten-Weiterleitungen vermeiden"
 
         /*
-         * The getDetails() method returns is a wrapper to yield the summary field as well as urlblocks data. 
+         * The getDetails() method is a wrapper to get the `summary` field as well as `Urlblocks` data. You
+         * can use $ruleResult->getUrlBlocks() and $ruleResult->getSummary() instead. 
          */
         foreach($ruleResult->getDetails() as $block) {
             var_dump($block->toString()); // "Auf Ihrer Seite sind keine Weiterleitungen vorhanden"

bin/phpunit.bat

@@ -1,2 +1,2 @@
 @echo off
-vendor/bin/phpunit --bootstrap "D:\xampp\htdocs\test\phpinsights\src\autoload.php"
+vendor/bin/phpunit --bootstrap "D:\xampp\htdocs\test\phpinsights\src\autoload.php" --report-useless-tests

tests/InsightsResponseTest.php

@@ -18,14 +18,7 @@ protected function setUp()
 
     }
 
-    /**
-     * @return InsightsResult
-     */
-    protected function getMappedResult() {
-        return $this->exampleComResponse->getMappedResult();
-    }
-
-    public function testValidResponse()
+     public function testValidResponse()
     {
         $this->assertInstanceOf(InsightsResponse::class, InsightsResponse::fromResponse(new Response(200, [], '{}')));
     }
@@ -53,34 +46,7 @@ public function testRawResult()
 
     public function testMappedResult()
     {
-        $this->assertInstanceOf(InsightsResult::class, $this->getMappedResult());
-    }
-
-    public function testResponseCode()
-    {
-        $this->assertEquals(200, $this->getMappedResult()->getResponseCode());
-    }
-
-    public function testKind()
-    {
-        $this->assertEquals('pagespeedonline#result', $this->getMappedResult()->getKind());
-    }
-
-    public function testId()
-    {
-        $this->assertEquals('http://example.com/', $this->getMappedResult()->getId());
-    }
-
-    public function testScreenshot()
-    {
-        $this->assertEquals('image/jpeg', $this->getMappedResult()->getScreenshot()->getMimeType());
-    }
-
-    public function testPageStats()
-    {
-        $this->assertEquals(33, $this->getMappedResult()->getPageStats()->getTotalRequestBytes());
-        $this->assertEquals(1599, $this->getMappedResult()->getPageStats()->getHtmlResponseBytes());
-
+        $this->assertInstanceOf(InsightsResult::class, $this->exampleComResponse->getMappedResult());
     }
 
 

tests/Result/InsightsResultTest.php

@@ -0,0 +1,56 @@
+<?php
+
+use GuzzleHttp\Psr7\Response;
+use PhpInsights\Result\InsightsResult;
+use PHPUnit\Framework\TestCase;
+use PhpInsights\InsightsResponse;
+
+class InsightsResultTest extends TestCase
+{
+
+    /** @var InsightsResponse */
+    protected $exampleComResponse;
+
+
+    protected function setUp()
+    {
+        $this->exampleComResponse = InsightsResponse::fromJson(file_get_contents(__DIR__ . '/../example-com-response.json'));
+        
+    }
+
+    /**
+     * @return InsightsResult
+     */
+    protected function getMappedResult() {
+        return $this->exampleComResponse->getMappedResult();
+    }
+
+    public function testResponseCode()
+    {
+        $this->assertEquals(200, $this->getMappedResult()->getResponseCode());
+    }
+
+    public function testKind()
+    {
+        $this->assertEquals('pagespeedonline#result', $this->getMappedResult()->getKind());
+    }
+
+    public function testId()
+    {
+        $this->assertEquals('http://example.com/', $this->getMappedResult()->getId());
+    }
+
+    public function testScreenshot()
+    {
+        $this->assertEquals('image/jpeg', $this->getMappedResult()->getScreenshot()->getMimeType());
+    }
+
+    public function testPageStats()
+    {
+        $this->assertEquals(33, $this->getMappedResult()->getPageStats()->getTotalRequestBytes());
+        $this->assertEquals(1599, $this->getMappedResult()->getPageStats()->getHtmlResponseBytes());
+
+    }
+
+
+}