Bugfix for calculating PCT values

[TatianaBurek]

Describe the Problem

It is possible that sum_n_i_orig_T value is 0 when there is no data available for the parameters. In this case agg_stat.py is failing and exiting without further calculations:
agg_stat.py line 1092

# calculate o_bar
o_bar = oy_total / sum_n_i_orig_T

need to anticipate and handle this situation
Suggestion:

 # calculate o_bar
 if sum_n_i_orig_T != 0:
                            o_bar = oy_total / sum_n_i_orig_T
 else:
                            o_bar = None

scorecard_rrfs_REFC_prob.agg_stat.info.txt
scorecard_rrfs_REFC_prob.data.agg_stat.txt

Expected Behavior

Provide a clear and concise description of what you expected to happen here.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

• Select engineer(s) or no engineer required
• Select scientist(s) or no scientist required

Labels

• Select component(s)
• Select priority
• Select requestor(s)

Projects and Milestone

• Select Organization level Project for support of the current coordinated release
• Select Repository level Project for development toward the next official release or add alert: NEED CYCLE ASSIGNMENT label
• Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy

Bugfix Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of main_<Version>.
  Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
• Fix the bug and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Add any new Python packages to the METplus Components Python Requirements table.
• Push local changes to GitHub.
• Submit a pull request to merge into main_<Version>.
  Pull request: bugfix <Issue Number> main_<Version> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Development issues
  Select: Organization level software support Project for the current coordinated release
  Select: Milestone as the next bugfix version
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Complete the steps above to fix the bug on the develop branch.
  Branch name: bugfix_<Issue Number>_develop_<Description>
  Pull request: bugfix <Issue Number> develop <Description>
  Select: Reviewer(s) and Development issues
  Select: Repository level development cycle Project for the next official release
  Select: Milestone as the next official version
• Close this issue.

[bikegeek]

The suggested fix (now at line 1492) does not address the problem in the _proceed-with_axis() method. New error occurs while calculating the Brier skill score, due to the addition of logging. Due to the dynamic determination of statistics calculations (i.e. statistic module names to be used are created during run-time), the function signatures need to be visited with respect to logging (some functions expect a boolean for whether or not logging is to be performed, while others only expect a logger object).

Will change status to 'stalled', pending further direction/funding.