Merge pull request #121 from duckdb/jray/accept-null-or-undef-for-logical-type-alias

jraymakers · web-flow · commit 4bfbb6d59cf6 · 2025-01-25T10:38:57.000-08:00
accept null or undefined for logical type alias
diff --git a/api/src/DuckDBLogicalType.ts b/api/src/DuckDBLogicalType.ts
@@ -145,8 +145,8 @@ export class DuckDBLogicalType {
   public get alias(): string | undefined {
     return duckdb.logical_type_get_alias(this.logical_type) || undefined;
   }
-  public set alias(newAlias: string) {
-    duckdb.logical_type_set_alias(this.logical_type, newAlias);
+  public set alias(newAlias: string | null | undefined) {
+    duckdb.logical_type_set_alias(this.logical_type, newAlias || '');
   }
   public asType(): DuckDBType {
     const alias = this.alias;

Original file line number	Diff line number	Diff line change
`@@ -145,8 +145,8 @@ export class DuckDBLogicalType {`
`145`	`145`	`public get alias(): string \| undefined {`
`146`	`146`	`return duckdb.logical_type_get_alias(this.logical_type) \|\| undefined;`
`147`	`147`	`}`
`148`		`- public set alias(newAlias: string) {`
`149`		`- duckdb.logical_type_set_alias(this.logical_type, newAlias);`
	`148`	`+ public set alias(newAlias: string \| null \| undefined) {`
	`149`	`+ duckdb.logical_type_set_alias(this.logical_type, newAlias \|\| '');`
`150`	`150`	`}`
`151`	`151`	`public asType(): DuckDBType {`
`152`	`152`	`const alias = this.alias;`