From 3760d0a52918f04f1db05acaaa040ca2cca5f357 Mon Sep 17 00:00:00 2001 From: arkw Date: Sun, 22 Sep 2024 11:03:08 +0900 Subject: [PATCH 1/5] separete it test --- packages/duckdb-wasm/test/httpfs_test.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/duckdb-wasm/test/httpfs_test.ts b/packages/duckdb-wasm/test/httpfs_test.ts index a48a11a50..d5ed44f6d 100644 --- a/packages/duckdb-wasm/test/httpfs_test.ts +++ b/packages/duckdb-wasm/test/httpfs_test.ts @@ -313,16 +313,17 @@ export function testHTTPFSAsync( ), ).toBeRejectedWithError('Invalid Error: File is not opened in write mode'); }); + }); - it('can read parquet file from URL with long query string', async () => { + describe('Long URL and Query String Tests', () => { + it('can read parquet file', async () => { const queryString = generateLongQueryString(); const result = await conn!.query( `SELECT * FROM "${S3_ENDPOINT}/${BUCKET_NAME}/correct_auth_test.parquet?${queryString}";`, ); expect(Number((result.getChildAt(0)?.get(6)))).toEqual(Number(29120)); }); - - it('can read csv file from URL with long query string', async () => { + it('can read csv file', async () => { const queryString = generateLongQueryString(); const result = await conn!.query( `SELECT * FROM "${S3_ENDPOINT}/${BUCKET_NAME}/correct_auth_test.csv?${queryString}";`, From f79ea45e2fa08968ab63dd6f9c2fb273c581bdd4 Mon Sep 17 00:00:00 2001 From: arkw Date: Sun, 22 Sep 2024 13:34:26 +0900 Subject: [PATCH 2/5] fix --- .github/workflows/main.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 9f786af61..0cb5d3d12 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -631,6 +631,12 @@ jobs: node-version: '18.x' registry-url: 'https://registry.npmjs.org' + - name: google-chrome version + shell: bash + run: | + CHROME_BIN=`which google-chrome` + $CHROME_BIN --version + - name: Git submodule status run: | git submodule status > git_submodule_status.txt @@ -945,6 +951,12 @@ jobs: node-version: '18.x' registry-url: 'https://registry.npmjs.org' + - name: google-chrome version + shell: bash + run: | + CHROME_BIN=`which google-chrome` + $CHROME_BIN --version + - name: Git submodule status run: | git submodule status > git_submodule_status.txt From ae7c26b2b72ab9b60f349882a029fa17e97b712d Mon Sep 17 00:00:00 2001 From: arkw Date: Sun, 22 Sep 2024 13:39:09 +0900 Subject: [PATCH 3/5] fix --- .github/workflows/main.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 0cb5d3d12..f6e8fd296 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -634,8 +634,7 @@ jobs: - name: google-chrome version shell: bash run: | - CHROME_BIN=`which google-chrome` - $CHROME_BIN --version + CHROME_BIN=`which google-chrome` $CHROME_BIN --version - name: Git submodule status run: | @@ -954,8 +953,7 @@ jobs: - name: google-chrome version shell: bash run: | - CHROME_BIN=`which google-chrome` - $CHROME_BIN --version + CHROME_BIN=`which google-chrome` $CHROME_BIN --version - name: Git submodule status run: | From b9ad0680634a41b289b26a14bec9a2d657058771 Mon Sep 17 00:00:00 2001 From: arkw Date: Sun, 22 Sep 2024 16:42:15 +0900 Subject: [PATCH 4/5] fix --- .github/workflows/main.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f6e8fd296..d31fd6887 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -635,6 +635,7 @@ jobs: shell: bash run: | CHROME_BIN=`which google-chrome` $CHROME_BIN --version + node --version - name: Git submodule status run: | @@ -954,6 +955,7 @@ jobs: shell: bash run: | CHROME_BIN=`which google-chrome` $CHROME_BIN --version + node --version - name: Git submodule status run: | From ac87ba264ec2d99a6b693f0d6e1ba43a95b70583 Mon Sep 17 00:00:00 2001 From: arkw Date: Sun, 22 Sep 2024 17:25:01 +0900 Subject: [PATCH 5/5] fix --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d31fd6887..560a2f871 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -948,7 +948,7 @@ jobs: - uses: actions/setup-node@v4 with: - node-version: '18.x' + node-version: '20.x' registry-url: 'https://registry.npmjs.org' - name: google-chrome version