refactor(api): redundant w_pos_changed assignment neovim#35663

glepnir · dundargoc · commit db3b0994bbe4 · 2025-09-27T19:54:35.000+02:00
Problem: w_pos_changed flag was being set redundantly after win_config_float call

Solution: remove duplicate assignment since win_config_float already sets this flag internally
diff --git a/src/nvim/api/win_config.c b/src/nvim/api/win_config.c
@@ -633,7 +633,6 @@ void nvim_win_set_config(Window window, Dict(win_config) *config, Error *err)
     }
   } else {
     win_config_float(win, fconfig);
-    win->w_pos_changed = true;
   }
   if (HAS_KEY_X(config, style)) {
     if (fconfig.style == kWinStyleMinimal) {

Original file line number	Diff line number	Diff line change
`@@ -633,7 +633,6 @@ void nvim_win_set_config(Window window, Dict(win_config) config, Error err)`
`633`	`633`	`}`
`634`	`634`	`} else {`
`635`	`635`	`win_config_float(win, fconfig);`
`636`		`- win->w_pos_changed = true;`
`637`	`636`	`}`
`638`	`637`	`if (HAS_KEY_X(config, style)) {`
`639`	`638`	`if (fconfig.style == kWinStyleMinimal) {`