Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog file location not conform XBRL spec #4

Open
fourth44 opened this issue Jul 22, 2022 · 1 comment
Open

Catalog file location not conform XBRL spec #4

fourth44 opened this issue Jul 22, 2022 · 1 comment

Comments

@fourth44
Copy link

Hi Chris! Hope you are doing well!

According to https://www.xbrl.org/Specification/taxonomy-package/REC-2016-04-19/taxonomy-package-REC-2016-04-19.html,
a taxonomy package zip should contain only a single root entry, which is a folder with the same name as the zip file itself:

A Taxonomy Package MUST contain a single top-level directory, with all other files being contained within that directory or descendant subdirectories (tpe:invalidDirectoryStructure). It is recommended, but not required, that the name of the top-level directory be the same as the name of the Taxonomy Package with the .zip file extension removed.

In any case it's easy to assume they mean the implicit root of every zip file, but in fact they truly mean that an explicit single folder should be inside the zip.

Currently TQA assumes a top level folder "META-INF/catalog.xml", but that should rather be "???/META-INF/catalog.xml" (see TaxonomyBaseFactoryFromRemoteZip.scala and TaxonomyPackagePartialUriResolver.scala).

fourth44 pushed a commit to fourth44/tqa that referenced this issue Jul 22, 2022
Proposed solution for issue dvreeze#4
@dvreeze
Copy link
Owner

dvreeze commented Jul 31, 2022

Hi Johan! Sorry for my late reply. I agree with the issue and your fix. Just an idea: does it make sense for you to fork TQA (and if needed yaidom) to make that the leading fork in practice, until you can entirely replace it with something better, less XML-centric and more modern?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants