Skip to content

Commit 48d4e2e

Browse files
Merge pull request #123 from JosephHobbs/main
converting audit Category from enum to string
2 parents 6be54eb + b0e0478 commit 48d4e2e

File tree

2 files changed

+4
-14
lines changed

2 files changed

+4
-14
lines changed

dynatrace/environment_v2/audit_logs.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -66,16 +66,6 @@ class EventType(Enum):
6666
UPDATE = "UPDATE"
6767

6868

69-
class Category(Enum):
70-
ACTIVEGATE_TOKEN = "ACTIVEGATE_TOKEN"
71-
CONFIG = "CONFIG"
72-
DEBUG_UI = "DEBUG_UI"
73-
MANUAL_TAGGING_SERVICE = "MANUAL_TAGGING_SERVICE"
74-
REST = "REST"
75-
TOKEN = "TOKEN"
76-
WEB_UI = "WEB_UI"
77-
78-
7969
class UserType(Enum):
8070
PUBLIC_TOKEN_IDENTIFIER = "PUBLIC_TOKEN_IDENTIFIER"
8171
REQUEST_ID = "REQUEST_ID"
@@ -86,7 +76,7 @@ class UserType(Enum):
8676

8777
class AuditLogEntry(DynatraceObject):
8878
def _create_from_raw_data(self, raw_element: Dict[str, Any]):
89-
self.category: Category = Category(raw_element.get("category"))
79+
self.category: str = raw_element.get("category")
9080
self.environment_id: str = raw_element.get("environmentId")
9181
self.event_type: EventType = EventType(raw_element.get("eventType"))
9282
self.log_id: str = raw_element.get("logId")

test/environment_v2/test_audit_logs.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from dynatrace import Dynatrace
22
from datetime import datetime
33

4-
from dynatrace.environment_v2.audit_logs import AuditLogEntry, EventType, Category, UserType
4+
from dynatrace.environment_v2.audit_logs import AuditLogEntry, EventType, UserType
55
from dynatrace.pagination import PaginatedList
66

77

@@ -16,7 +16,7 @@ def test_list(dt: Dynatrace):
1616
assert isinstance(first, AuditLogEntry)
1717
assert first.log_id == "162100314800090003"
1818
assert first.event_type == EventType("DELETE")
19-
assert first.category == Category("CONFIG")
19+
assert first.category == "CONFIG"
2020
assert first.entity_id == "builtin:alerting.profile (tenant): d89472d3-f9f4-420d-9398-768bb3351e85: test"
2121
assert first.environment_id == "eaa50379"
2222
assert first.user == "Dynatrace support user #649982176"
@@ -31,7 +31,7 @@ def test_get(dt: Dynatrace):
3131
assert isinstance(audit_log, AuditLogEntry)
3232
assert audit_log.log_id == "162100314800090003"
3333
assert audit_log.event_type == EventType("DELETE")
34-
assert audit_log.category == Category("CONFIG")
34+
assert audit_log.category == "CONFIG"
3535
assert audit_log.entity_id == "builtin:alerting.profile (tenant): d89472d3-f9f4-420d-9398-768bb3351e85: test"
3636
assert audit_log.environment_id == "eaa50379"
3737
assert audit_log.user == "Dynatrace support user #649982176"

0 commit comments

Comments
 (0)