Fix parsing; parallelize

Author: ValentaTomas

.github/workflows/build.yml

@@ -0,0 +1,44 @@
+name: Build Firecracker Versions
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+  workflow_dispatch:
+
+jobs:
+  prepare:
+    runs-on: ubuntu-latest
+    outputs:
+      versions: ${{ steps.set-versions.outputs.versions }}
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Parse versions from file
+        id: set-versions
+        run: |
+          # Read versions, skip comments and empty lines, output as JSON array
+          versions=$(grep -v '^ *#' firecracker_versions.txt | grep -v '^$' | jq -R -s -c 'split("\n") | map(select(length > 0))')
+          echo "versions=$versions" >> $GITHUB_OUTPUT
+          echo "Building versions: $versions"
+
+  build:
+    needs: prepare
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        version: ${{ fromJson(needs.prepare.outputs.versions) }}
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Build Firecracker ${{ matrix.version }}
+        run: ./build.sh "${{ matrix.version }}"
+
+      - name: Upload build artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: firecracker-${{ matrix.version }}
+          path: builds/
+          retention-days: 30

build.sh

@@ -6,13 +6,40 @@ FIRECRACKER_REPO_URL="https://github.com/e2b-dev/firecracker.git"
 
 function build_version {
   local version=$1
-  echo "Starting build for Firecracker commit: $version"
 
-  echo "Checking out repo for Firecracker at commit: $version"
-  git checkout "${version}"
+  # Detect if the version is of the form tag_shorthash (e.g., v1.12.1_abcdef12)
+  if [[ "$version" =~ ^([^_]+)_([0-9a-fA-F]+)$ ]]; then
+    local tag="${BASH_REMATCH[1]}"
+    local shorthash="${BASH_REMATCH[2]}"
+    echo "Starting build for Firecracker tag: $tag and shorthash: $shorthash"
+
+    echo "Checking out repo at tag: $tag"
+    git checkout "$tag"
+
+    # Find full hash from shorthash
+    fullhash=$(git rev-parse --verify "$shorthash^{commit}" 2>/dev/null || true)
+    if [[ -z "$fullhash" ]]; then
+      echo "Error: Could not resolve hash $shorthash"
+      exit 1
+    fi
+
+    # Ensure that $fullhash is a descendant of $tag
+    if git merge-base --is-ancestor "$tag" "$fullhash"; then
+      echo "Shorthash $shorthash is AFTER tag $tag -- proceeding"
+      git checkout "$fullhash"
+    else
+      echo "Error: shorthash $shorthash is not a descendant of tag $tag"
+      exit 1
+    fi
+    version_name="${tag}_$shorthash"
+  else
+    echo "Starting build for Firecracker at commit: $version"
+    echo "Checking out repo for Firecracker at commit: $version"
+    git checkout "${version}"
+    # The format will be: latest_tag_latest_commit_hash — v1.7.0-dev_g8bb88311
+    version_name=$(git describe --tags --abbrev=0 "$(git rev-parse HEAD)")_$(git rev-parse --short HEAD)
+  fi
 
-  # The format will be: latest_tag_latest_commit_hash — v1.7.0-dev_g8bb88311
-  version_name=$(git describe --tags --abbrev=0 $(git rev-parse HEAD))_$(git rev-parse --short HEAD)
   echo "Version name: $version_name"
 
   echo "Building Firecracker version: $version_name"
@@ -23,11 +50,19 @@ function build_version {
   cp build/cargo_target/x86_64-unknown-linux-musl/release/firecracker "../builds/${version_name}/firecracker"
 }
 
+# If a version is passed as argument, build only that version
+# Otherwise, build all versions from firecracker_versions.txt
+if [[ $# -ge 1 ]]; then
+  versions=("$@")
+else
+  mapfile -t versions < <(grep -v '^ *#' firecracker_versions.txt | grep -v '^$')
+fi
+
 echo "Cloning the Firecracker repository"
 git clone $FIRECRACKER_REPO_URL firecracker
 cd firecracker
 
-grep -v '^ *#' <../firecracker_versions.txt | while IFS= read -r version; do
+for version in "${versions[@]}"; do
   build_version "$version"
 done