Skip to content

fix(api): correct error log message in RemoveSandbox #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakubno merged 2 commits into from
Apr 19, 2026
Merged

fix(api): correct error log message in RemoveSandbox #2449

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88a38c4
fix(api): correct error log message in RemoveSandbox
jakubno Apr 19, 2026
0776f8f
fix(api): include state_action on RemoveSandbox error log
jakubno Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/api/internal/orchestrator/delete_instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,11 @@ func (o *Orchestrator) RemoveSandbox(ctx context.Context, teamID uuid.UUID, sand
defer o.sandboxStore.Remove(context.WithoutCancel(ctx), teamID, sandboxID)
err = o.removeSandboxFromNode(ctx, sbx, opts.Action)
if err != nil {
logger.L().Error(ctx, "Error pausing sandbox", zap.Error(err), logger.WithSandboxID(sbx.SandboxID))
logger.L().Error(ctx, "Error removing sandbox",
zap.String("state_action", opts.Action.Name),
zap.Error(err),
logger.WithSandboxID(sbx.SandboxID),
)

return ErrSandboxOperationFailed
}
Expand Down
Loading