v0.18.2.pre

Author: Unai Abrisketa

.rubocop.yml

@@ -0,0 +1,33 @@
+require:
+  - rubocop-ordered_methods
+  - rubocop-rspec
+
+AllCops:
+  NewCops: enable
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Metrics/AbcSize:
+  Enabled: false
+Metrics/MethodLength:
+  Enabled: false
+Metrics/BlockLength:
+  Enabled: false
+Metrics/ClassLength:
+  Enabled: false
+Style/Documentation:
+  Enabled: false
+Metrics/CyclomaticComplexity:
+  Enabled: false
+Metrics/PerceivedComplexity:
+  Enabled: false
+
+Layout/LineLength:
+  IgnoredPatterns: ['(\A|\s)#']
+
+Style/AsciiComments:
+  Enabled: false
+
+Style/SymbolArray:
+  EnforcedStyle: brackets

CHANGELOG.md

@@ -1,7 +1,18 @@
+### v0.18.2.pre
+
+* bug-fixes
+  * Move `#products.update_reserve_stock` from `POST` to `PUT`.
+
+* enhancements
+  * Update how `api_url` is set on `BeyondApi::Session`.
+
+* features
+  * Install, configure and fix most of the Rubocop issues.
+
 ### v0.18.1.pre
 
 * bug-fixes
-  * Prevent logging `code` and `refresh_token` on `/api/token` calls
+  * Prevent logging `code` and `refresh_token` on `/api/token` calls.
 
 ### v0.18.0.pre
 

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 # Specify your gem's dependencies in beyond_api.gemspec

Gemfile.lock

@@ -1,12 +1,13 @@
 PATH
   remote: .
   specs:
-    beyond_api (0.18.1.pre)
+    beyond_api (0.18.2.pre)
       faraday (~> 0.15)
 
 GEM
   remote: https://rubygems.org/
   specs:
+    ast (2.4.2)
     coderay (1.1.3)
     concurrent-ruby (1.1.9)
     diff-lcs (1.4.4)
@@ -19,10 +20,16 @@ GEM
       concurrent-ruby (~> 1.0)
     method_source (1.0.0)
     multipart-post (2.1.1)
+    parallel (1.20.1)
+    parser (3.0.2.0)
+      ast (~> 2.4.1)
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
+    rainbow (3.0.0)
     rake (10.5.0)
+    regexp_parser (2.1.1)
+    rexml (3.2.5)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)
       rspec-expectations (~> 3.10.0)
@@ -36,6 +43,24 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-support (3.10.2)
+    rubocop (1.20.0)
+      parallel (~> 1.10)
+      parser (>= 3.0.0.0)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml
+      rubocop-ast (>= 1.9.1, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.11.0)
+      parser (>= 3.0.1.1)
+    rubocop-ordered_methods (0.9)
+      rubocop (>= 1.0)
+    rubocop-rspec (2.4.0)
+      rubocop (~> 1.0)
+      rubocop-ast (>= 1.1.0)
+    ruby-progressbar (1.11.0)
+    unicode-display_width (2.0.0)
     yard (0.9.26)
 
 PLATFORMS
@@ -49,6 +74,9 @@ DEPENDENCIES
   pry
   rake (~> 10.0)
   rspec (~> 3.0)
+  rubocop (~> 1.20)
+  rubocop-ordered_methods (~> 0.9)
+  rubocop-rspec (~> 2.4)
   yard (~> 0.9)
 
 BUNDLED WITH

Rakefile

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 require "yard"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec
 
 YARD::Rake::YardocTask.new do |t|
- t.files   = ['lib/**/*.rb']
+  t.files = ["lib/**/*.rb"]
 end

beyond_api.gemspec

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "beyond_api/version"
 
@@ -11,7 +12,7 @@ Gem::Specification.new do |spec|
   spec.summary       = "Ruby client to access the Beyond API"
   spec.homepage      = "https://github.com/ePages-de/beyond_api-ruby_client"
 
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files         = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
   spec.bindir        = "exe"
@@ -20,12 +21,15 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = ">= 2.5.1"
 
-  spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "rake",    "~> 10.0"
-  spec.add_development_dependency "rspec",   "~> 3.0"
-  spec.add_development_dependency "yard",    "~> 0.9"
-  spec.add_development_dependency "faker",   "~> 2.2"
-  spec.add_development_dependency "dotenv",  "~> 2.7"
+  spec.add_development_dependency "bundler",                 "~> 2.0"
+  spec.add_development_dependency "dotenv",                  "~> 2.7"
+  spec.add_development_dependency "faker",                   "~> 2.2"
+  spec.add_development_dependency "rake",                    "~> 10.0"
+  spec.add_development_dependency "rspec",                   "~> 3.0"
+  spec.add_development_dependency "rubocop",                 "~> 1.20"
+  spec.add_development_dependency "rubocop-ordered_methods", "~> 0.9"
+  spec.add_development_dependency "rubocop-rspec",           "~> 2.4"
+  spec.add_development_dependency "yard",                    "~> 0.9"
 
   spec.add_dependency "faraday", "~> 0.15"
 end

bin/console

@@ -1,10 +1,11 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require "bundler/setup"
 require "dotenv/load"
 require "beyond_api"
 
-unless ENV["CLIENT_ID"].nil? and ENV["CLIENT_SECRET"].nil?
+unless ENV["CLIENT_ID"].nil? && ENV["CLIENT_SECRET"].nil?
   BeyondApi.setup do |config|
     config.client_id = ENV["CLIENT_ID"]
     config.client_secret = ENV["CLIENT_SECRET"]

lib/beyond_api.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "beyond_api/version"
 
 require "logger"
@@ -25,7 +27,7 @@ def self.setup
   end
 
   class Configuration
-    attr_accessor :client_id, :client_secret, :open_timeout, :timeout,  :remove_response_links,
+    attr_accessor :client_id, :client_secret, :open_timeout, :timeout, :remove_response_links,
                   :remove_response_key_underscores, :object_struct_responses, :raise_error_requests,
                   :log_headers, :log_bodies, :log_level, :all_pagination_size
 

lib/beyond_api/connection.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'faraday'
+require "faraday"
 
 module BeyondApi
   class Connection
@@ -13,8 +13,8 @@ def self.default
         faraday.options[:timeout] = BeyondApi.configuration.timeout.to_i
         faraday.response :logger, LOGGER, { headers: BeyondApi.configuration.log_headers,
                                             bodies: BeyondApi.configuration.log_bodies }
-        faraday.headers['Accept'] = 'application/json'
-        faraday.headers['Content-Type'] = 'application/json'
+        faraday.headers["Accept"] = "application/json"
+        faraday.headers["Content-Type"] = "application/json"
         faraday.request(:multipart)
         faraday.request(:url_encoded)
         faraday.adapter(:net_http)

lib/beyond_api/error.rb

@@ -5,15 +5,15 @@ class Error < StandardError
     attr_reader :error_id, :details, :trace_id, :full_message, :status_code, :error, :error_description
 
     def initialize(data, status_code = nil)
-      @error_id          = data['errorId']
-      @details           = data['details']
-      @trace_id          = data['traceId']
-      @error             = data['error']
-      @error_description = data['error_description']
+      @error_id          = data["errorId"]
+      @details           = data["details"]
+      @trace_id          = data["traceId"]
+      @error             = data["error"]
+      @error_description = data["error_description"]
       @full_message      = data
       @status_code       = status_code
 
-      super(data['message'] || data['error_description'])
+      super(data["message"] || data["error_description"])
     end
   end
 end