Disable flacky tests (#192)

* add helper to analyze SWTBot context
* improved report of swt status in case of failure
* prevent race condition in updating sirius representations
* change Sirius notification refresh stategy to command queue

this prevent multiple simultaneous call to refresh sirius
representation. however, everything is refreshed at last thanks to the
queue

* use swtbot UIThreadRunnable instead of Display.syncExec

contribute to eclipse-gemoc/gemoc-studio#123

Signed-off-by: Didier Vojtisek <[email protected]>

Author: dvojtise

framework/execution_framework/plugins/org.eclipse.gemoc.executionframework.extensions.sirius/src/org/eclipse/gemoc/executionframework/extensions/sirius/services/AbstractGemocDebuggerServices.java

@@ -56,6 +56,7 @@
 import org.eclipse.sirius.ui.business.api.session.SessionUIManager;
 import org.eclipse.sirius.viewpoint.DRepresentation;
 import org.eclipse.sirius.viewpoint.description.RepresentationDescription;
+import org.eclipse.swt.widgets.Display;
 
 
 /*
@@ -628,6 +629,14 @@ public void setCurrentFrame(String debugModelID, StackFrame frame) {
 				currentFrame = frame;
 				Set<URI> instructionUris = CURRENT_INSTRUCTIONS_PER_FRAME.get(getCurrentFrame());
 				if (instructionUris != null) {
+					// use async exec even if already run in UI Thread in order to prevent possible
+					// race conditions on sirius refresh
+					Display.getDefault().asyncExec(new Runnable() {
+						@Override
+						public void run() {
+							notifySirius(instructionUris, debugModelID);
+						}
+					});
 					notifySirius(instructionUris, debugModelID);
 				}
 			}

framework/execution_framework/plugins/org.eclipse.gemoc.executionframework.extensions.sirius/src/org/eclipse/gemoc/executionframework/extensions/sirius/ui/preferences/PreferenceInitializer.java

@@ -27,7 +27,7 @@ public class PreferenceInitializer extends AbstractPreferenceInitializer {
 	public void initializeDefaultPreferences() {
 		IPreferenceStore store = Activator.getDefault().getPreferenceStore();
 
-		store.setDefault(PreferenceConstants.P_REFRESH_STRATEGY, AnimationRefreshStrategy.Every.toString());
+		store.setDefault(PreferenceConstants.P_REFRESH_STRATEGY, AnimationRefreshStrategy.CommandQueue.toString());
 		store.setDefault(PreferenceConstants.P_REFRESH_FREQUENCY_LIMIT, 500);
 
 	}

framework/xdsml_framework/tests/org.eclipse.gemoc.xdsmlframework.test.lib/src/org/eclipse/gemoc/xdsmlframework/test/lib/SWTBotHelper.xtend

@@ -12,6 +12,19 @@ package org.eclipse.gemoc.xdsmlframework.test.lib
 
 import org.eclipse.swtbot.eclipse.finder.SWTWorkbenchBot
 
+import static org.eclipse.swtbot.swt.finder.matchers.WidgetMatcherFactory.allOf
+import static org.eclipse.swtbot.swt.finder.matchers.WidgetMatcherFactory.anyOf
+import static org.eclipse.swtbot.swt.finder.matchers.WidgetMatcherFactory.widgetOfType
+import static org.eclipse.swtbot.swt.finder.matchers.WidgetMatcherFactory.withStyle
+import static org.eclipse.swtbot.swt.finder.matchers.WidgetMatcherFactory.withTooltip
+import org.eclipse.swt.widgets.Button
+import org.eclipse.swt.widgets.ToolItem
+import org.eclipse.swt.widgets.Widget
+import java.util.List
+import org.eclipse.swt.widgets.Display
+import org.eclipse.swtbot.swt.finder.finders.UIThreadRunnable
+import org.eclipse.swtbot.swt.finder.results.VoidResult
+
 /**
  * Class containing helper methods for testing a workspace in a GEMOC Language workbench
  */
@@ -23,9 +36,69 @@ class SWTBotHelper {
 	 * also wait for idle time to triggers new jobs 
 	 */
 	static def void printShellList(SWTWorkbenchBot	bot) {
-		println("SWTBOT Known shells :")
-		for (shell : bot.shells) {
-			println("\t"+shell.text)
+		val shells = bot.shells.toList
+		println("SWTBot Known shells("+shells.size+"):")
+		for (shell : shells) {
+			println("\t"+shell)
+		}
+	}
+	
+	static def void printTreeList(SWTWorkbenchBot	bot) {
+		println("SWTBot tree(" + bot.tree().allItems.size + "):")
+		for (item : bot.tree().allItems) {
+			println("\t" + item)
+		}
+	}
+	
+	static def void printViewList(SWTWorkbenchBot	bot) {
+		val views = bot.views
+		println("SWTBot View(" + views.size + "):")
+		for (item : views) {
+			UIThreadRunnable.syncExec(new VoidResult() {
+				override run() {
+					println("\t" + item.title+ " "+ item.widget)
+					printWidgetList("\t\t","View ToolBarButton", item.toolbarButtons.map[swtBut | swtBut.widget].toList)
+				}
+			})
+		}
+	}
+	
+	static def printSWTBotStatus(SWTWorkbenchBot bot) {
+		println("### SWTBot context analysis ###")
+		printShellList(bot)
+		printViewList(bot)
+		printTreeList(bot)
+
+		UIThreadRunnable.syncExec(new VoidResult() {
+			override run() {
+				try {
+					val matcherButton = allOf(widgetOfType(typeof(Button) /*, withLabel(label), withStyle(SWT.PUSH, "SWT.PUSH")*/ ))
+					val buttons = bot.widgets(matcherButton).toList
+					printWidgetList("", "Button",buttons)
+				} catch (Exception e) {
+					println("SWTBot Button(0) [no Button in the UI after 20000ms]")
+					// this has required a 20000ms timeout but there is no Button in the bot now
+				}
+				val matcherToolItem = allOf(
+					widgetOfType(typeof(ToolItem))
+				// ,	anyOf(withTooltip("Step &Into (F5)"), withTooltip("Step &Into")), withStyle(SWT.PUSH, "SWT.PUSH")
+				)
+				val toolItems = bot.widgets(matcherToolItem).toList
+				printWidgetList("","ToolItem", toolItems)
+			}
+		})
+	}
+
+	static def printWidgetList(String indent, String itemType, List<? extends Widget> items) {
+		println(indent +"SWTBot " + itemType + "(" + items.size + "):")
+		for (item : items) {
+			if(item instanceof ToolItem) {
+				println(indent +"\t"+ item + " toolTipText="+item.toolTipText)
+			} else if(item instanceof Button) {
+				println(indent +"\t" + item + " text="+ item.text  + " toolTipText="+item.toolTipText)	
+			} else {
+				println(indent +"\t" + item)
+			}
 		}
 	}