Skip to content

Commit c7271dc

Browse files
authored
Disable 'allDimensions' feature in the trace edit view (#211)
* Disable 'allDimensions' feature in the trace edit view Fixes having dimensions shown twice in the view (ie. with bith 'dimensions' and 'allDimensions', while the former is derived from the latter) * Set '@generated NOT' on modified getChildrenFeatures method
1 parent d4d9ad6 commit c7271dc

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

trace/commons/plugins/org.eclipse.gemoc.trace.commons.model.edit/src/org/eclipse/gemoc/trace/commons/model/generictrace/provider/GenericTracedObjectItemProvider.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,20 +79,24 @@ protected void addOriginalObjectPropertyDescriptor(Object object) {
7979
null,
8080
null));
8181
}
82-
82+
8383
/**
8484
* This specifies how to implement {@link #getChildren} and is used to deduce an appropriate feature for an
8585
* {@link org.eclipse.emf.edit.command.AddCommand}, {@link org.eclipse.emf.edit.command.RemoveCommand} or
8686
* {@link org.eclipse.emf.edit.command.MoveCommand} in {@link #createCommand}.
8787
* <!-- begin-user-doc -->
8888
* <!-- end-user-doc -->
89-
* @generated
89+
* @generated NOT
9090
*/
9191
@Override
9292
public Collection<? extends EStructuralFeature> getChildrenFeatures(Object object) {
9393
if (childrenFeatures == null) {
9494
super.getChildrenFeatures(object);
95-
childrenFeatures.add(GenerictracePackage.Literals.GENERIC_TRACED_OBJECT__ALL_DIMENSIONS);
95+
96+
// NOTE: since "dimensions" is derived from "allDimensions", we must comment
97+
// the following generated line to avoid displaying each dimension twice in the edit view
98+
//
99+
// childrenFeatures.add(GenerictracePackage.Literals.GENERIC_TRACED_OBJECT__ALL_DIMENSIONS);
96100
}
97101
return childrenFeatures;
98102
}

0 commit comments

Comments
 (0)