-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual Thread model breaks tracing #5382
Comments
Can you please update the description? It seems the same piece of code is repeated in image/text formats, but some verticle snippets are missing. The description must let us understand how to reproduce the problem. Otherwise, we can only guess. |
Sorry for inconvenience, Description updated. Using ThreadingModel.VIRTUAL_THREAD causing tracing spans not binding together. Single change to ThreadingModel.WORKER fixes but WORKER model is not what we needed. |
Thanks for the update, but can you also add snippets of the other verticles that are deployed and instructions about requests to run so that we can try to reproduce? Thank you |
Full code added. @tsegismont |
Thanks, I'll look into this as soon as I can |
looking into it |
can you elaborate how the reproducers should be used ? |
I think it is duplicate of eclipse-vertx/vertx-tracing#92 |
Closing to invalid as it is a duplicate of an vertx OTEL bug fix. |
Description
Vert.x has 3 different thread models, worker, vthreads and standart. For high performance web application api we are using ThreadingModel.VIRTUAL _THREAD. However this model breaks tracing (open telemetry, datadog etc), spans are bind together.
If threading model switched to ThreadingModel.WORKER which is the only change, tracing works expectedly and spans bind together correctly.
Version
4.5.10
Context
When using vert.x virtual thread model, tracing breaks (datadog, opentelemetry etc.)
Do you have a reproducer?
Code:
The text was updated successfully, but these errors were encountered: