Merge pull request #181 from ecmwf-projects/fix-costing

handle max_cost_value of str type

Author: mcucchi9

cads_processing_api_service/costing.py

@@ -52,6 +52,7 @@ def compute_costing(
     max_costs: dict[str, Any] = costing_config.get("max_costs", {})
     max_costs_exceeded = {}
     for max_cost_id, max_cost_value in max_costs.items():
+        max_cost_value = float(max_cost_value)
         if max_cost_id in costs.keys():
             if costs[max_cost_id] > max_cost_value:
                 max_costs_exceeded[max_cost_id] = max_cost_value

tests/test_30_utils.py

@@ -16,6 +16,7 @@
 
 import datetime
 import unittest.mock
+import uuid
 from typing import Any
 
 import cacholote
@@ -211,8 +212,11 @@ def test_make_pagination_query_params() -> None:
 
 
 def test_dictify_job() -> None:
-    request = cads_broker.database.SystemRequest(request_id=0, status="failed")
-    exp_job = {"request_id": 0, "status": "failed"}
+    request_uid = uuid.uuid4()
+    request = cads_broker.database.SystemRequest(
+        request_uid=request_uid, status="failed"
+    )
+    exp_job = {"request_uid": request_uid, "status": "failed"}
     res_job = utils.dictify_job(request)
     assert isinstance(res_job, dict)
     assert all([key in res_job and res_job[key] == exp_job[key] for key in exp_job])