Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify length of Packet #9

Open
ecp4224 opened this issue Dec 16, 2017 · 0 comments
Open

Verify length of Packet #9

ecp4224 opened this issue Dec 16, 2017 · 0 comments

Comments

@ecp4224
Copy link
Owner

ecp4224 commented Dec 16, 2017

When the client sends a packet, verify that the length of the packet matches what the Packet requires.
This can be done using a verifyLength() function that gets checked before invoking handlePacket(). However, the netty pipeline may need to be reworked to ensure that packets are properly handled when a packet is BOTH to short or to long.

  • If a packet is to short, then netty should continue to listen for data and try again later
  • If a packet is to long, then the packet should be truncated and the tail end should be given back to netty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant